[GitHub] [incubator-nuttx] raiden00pl commented on pull request #1544: STM32 IO compensation cell initialization fix.

raiden00pl commented on pull request #1544: URL: https://github.com/apache/incubator-nuttx/pull/1544#issuecomment-672647458 @fjpanag From what I can see in the reference manuals, all of the H7 family support IO compensation cell but there are small differences in register bits for the late

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672635130 Sorry, the fix is here: https://github.com/apache/incubator-nuttx/pull/1566. Before the build system can handle this type of couple directly, it's better to me

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1566: Fix sam_ili9488.c:1605:7: error: label 'errout_with_dmadog' used but not defined

xiaoxiang781216 opened a new pull request #1566: URL: https://github.com/apache/incubator-nuttx/pull/1566 ## Summary introduced by commit a0ce81d65914fdedab4f7418442e3fdc12331b71 ## Impact ## Testing

[GitHub] [incubator-nuttx] v01d commented on pull request #1501: New Documentation

v01d commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672462708 > > PS: something to consider in the future is to write a parser for NuttX formatted comments used to document functions. This could then be used to automatically generate

[GitHub] [incubator-nuttx] patacongo commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672448930 All PR checks are now failing due to: sam_ili9488.c: In function 'board_lcd_initialize': sam_ili9488.c:1605:7: error: label 'errout_with_dmadog' used b

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1501: New Documentation

patacongo edited a comment on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672423392 > > > PS: something to consider in the future is to write a parser for NuttX formatted comments used to document functions. This could then be used to a

[GitHub] [incubator-nuttx] patacongo commented on pull request #1501: New Documentation

patacongo commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672423392 > > > PS: something to consider in the future is to write a parser for NuttX formatted comments used to document functions. This could then be used to automati

[GitHub] [incubator-nuttx] v01d commented on pull request #1501: New Documentation

v01d commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672417717 PS: something to consider in the future is to write a parser for NuttX formatted comments used to document functions. This could then be used to automatically generate the

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1501: New Documentation

adamfeuer commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672313248 @v01d @btashton Re: versioned releases going forward only, at least for now, I'm ok with that. Re: the supported boards, yeah, I think the new boards structure w

[GitHub] [incubator-nuttx] btashton commented on pull request #1501: New Documentation

btashton commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672309443 @v01d I am happy to wire up the CI as we had previously discussed, but yes I think that is for another PR. I wanted to wait for this to settle before hooking it into t

[GitHub] [incubator-nuttx] v01d commented on pull request #1501: New Documentation

v01d commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672308841 > @v01d This looks great! I owe the remaining changes for supported platforms– formatting and hyperlinks. I'll try to get that done by Sunday. Thanks! I was unsure if

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1501: New Documentation

adamfeuer commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672301746 @v01d This looks great! I owe the remaining changes for supported platforms–  formatting and hyperlinks. I'll try to get that done by Sunday. As for removing the

[GitHub] [incubator-nuttx] v01d commented on pull request #1501: New Documentation

v01d commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-672289394 Today I managed to finish the "reference" and "components" section, which is mostly the contents of the user and porting guide. There are two big ones that require consider

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672257134 > But don't use type void *. There are problems using type void * with certain architctures (AVR I think) that was fixed by created wdparm_t. Please continue to use wdparm_t

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672247919 > > > @papatience after reviewing all caller of wd_start, all place just need one argument so, the prototype can be simple as: > > ``` > typedef CODE void (*

[GitHub] [incubator-nuttx] patacongo commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672240823 > typedef CODE void (*wdentry_t)(FAR void *arg); I assume you meant (wdparm_t arg) not (FAR void *arg). wdparm_t handles all cases where uint32_t's and pointers

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #361: netutils/ftpc: Change watchdog callback prototype

xiaoxiang781216 opened a new pull request #361: URL: https://github.com/apache/incubator-nuttx-apps/pull/361 ## Summary follow up the kernel side change: https://github.com/apache/incubator-nuttx/pull/1565 ## Impact ## Testing -

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #740: problem with nxsig_timeout (sig_timedwait.c)

xiaoxiang781216 edited a comment on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672221606 @papatience after reviewing all caller of wd_start, all place just need one argument so, the prototype can be simple as: ``` typedef CODE void (*wdentry_t)(

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

xiaoxiang781216 commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672221606 @papatience after reviewing all caller of wd_start, all place just need one argument so, the prototype can be simple as: ``` typedef CODE void (*wdentry_t)(FAR voi

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo edited a comment on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672212866 The inefficiency in the proposal should be considered as well. You once told me that all calls to wd_start() but one provided only a single parameter. it sems wastef

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1565: sched/wdog: Remove MAX_WDOGPARMS and related stuff

xiaoxiang781216 opened a new pull request #1565: URL: https://github.com/apache/incubator-nuttx/pull/1565 ## Summary since the variable arguments are error prone and seldom used. See the dissussion here: https://github.com/apache/incubator-nuttx/issues/740 ## Impact ## Test

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672215889 The old saying applies here: "If it is not broken, then don't fix it." Nothing is broken, no change is necessary. Achieving code stability is really more important th

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672212866 The inefficiency in the proposal should be considered as well. You once told me that all calls to wd_start() but one provided only a single parameter. it sems wasteful to s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468805731 ## File path: arch/arm/src/samv7/sam_ssc.c ## @@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv) static void ssc

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1564: sensors/ak09912: Ensure ak09912_dev_s zero in ak09912_register

xiaoxiang781216 opened a new pull request #1564: URL: https://github.com/apache/incubator-nuttx/pull/1564 ## Summary Forget in patch: https://github.com/apache/incubator-nuttx/pull/1545 ## Impact ## Testing --

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468805731 ## File path: arch/arm/src/samv7/sam_ssc.c ## @@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv) static void ssc

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672202008 > What controls the "life" of structure pointed to by "arg". It cannot be in a stack and it can become stale if it is in allocated memory. In general, it cannot be a static v

[GitHub] [incubator-nuttx] patacongo commented on issue #740: problem with nxsig_timeout (sig_timedwait.c)

patacongo commented on issue #740: URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672195129 > The minimum essential changes for the portability are included in the PR, but > if possible, I think that the API spec of wd_start() should be changed. > Because the c

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

hartmannathan commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672176554 On Tue, Aug 11, 2020 at 2:24 PM Xiang Xiao wrote: > If the compatibility is important, wd_create/wd_delete could keep as > before. But because the new usa

[incubator-nuttx-apps] 02/02: Fix nxstyle warning

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit ebf37162ed9c0691de6ce39a28b42c00f28bb200 Author: Xiang Xiao AuthorDate: Mon Aug 10 02:50:43 2020 +0800

[incubator-nuttx-apps] 01/02: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit bf4c36c83f180b348bd9a4b171ad8e5e46d5d1e6 Author: Xiang Xiao AuthorDate: Mon Aug 10 02:31:34 2020 +0800

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

patacongo merged pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-nuttx-apps] branch master updated (e6c5ff9 -> ebf3716)

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from e6c5ff9 Remove the unnecessary touch and clean from Makefile new bf4c36c netutils/ftpc: Embed wdo

[incubator-nuttx] branch master updated (4df42ba -> ae94688)

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4df42ba libc/ftw: Fix error: cast between incompatible function types from 'ftw_cb_t' nftw_cb_t add a0

[GitHub] [incubator-nuttx] patacongo merged pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo merged pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672162616 > On Tue, Aug 11, 2020 at 11:36 AM patacongo ***@***.***> wrote: @btashton @hartmannathan

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672162616 > On Tue, Aug 11, 2020 at 11:36 AM patacongo ***@***.***> wrote: @btashton @hartmannathan @Ouss4

[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #358: Remove the unnecessary touch and delete from Makefile

Ouss4 merged pull request #358: URL: https://github.com/apache/incubator-nuttx-apps/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx-apps] branch master updated: Remove the unnecessary touch and clean from Makefile

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new e6c5ff9 Remove the unnecessa

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468768217 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468703707 ## File path: Documentation/NuttxUserGuide.html ## @@ -10139,7 +10139,6 @@ 2.12.4 shmdt struct tcb_s mqd_t sem_t -WDOG_ID pthread_key_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1561: Fix in STM32F4 over-drive configuration.

xiaoxiang781216 commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672125287 @fjpanag you can change "Public Functions" to "Public Function Prototypes" This is an automated

[GitHub] [incubator-nuttx] davids5 commented on pull request #1561: Fix in STM32F4 over-drive configuration.

davids5 commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672107061 >However, as I touched the files arch/arm/src/stm32/stm32_pwr.h & arch/arm/src/stm32/stm32_pwr.c CI complains about styling issues. I fixed as much as I could, but I am

[GitHub] [incubator-nuttx] fjpanag commented on pull request #1561: Fix in STM32F4 over-drive configuration.

fjpanag commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672082852 I feel that this completes the changes related to over-drive. I will work on another branch (possibly after vacation) on making regulator scale configurable too.

[GitHub] [incubator-nuttx] johannes-nivus edited a comment on pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

johannes-nivus edited a comment on pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#issuecomment-672081823 At all: I'll rework the PR since I'm sure it is correct to signal the actual available amount of cache inside adj_stack_size. But I must admit, it is

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

johannes-nivus commented on pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#issuecomment-672081823 @all I'll rework the PR since I'm sure it is correct to signal the actual available amount of cache inside adj_stack_size. But I must admit, it is not perfe

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

xiaoxiang781216 commented on pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357#issuecomment-672074197 Just see you already opened an issue for this: https://github.com/apache/incubator-nuttx-apps/issues/360 ---

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

xiaoxiang781216 commented on pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357#issuecomment-672073297 Yes, I will open an issue track this problem. This is an automated message from the Apache G

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1558: stack check: Support Stack Smashing Protector(SSP)

xiaoxiang781216 commented on a change in pull request #1558: URL: https://github.com/apache/incubator-nuttx/pull/1558#discussion_r468570685 ## File path: libs/libc/stdlib/lib_stackchk.c ## @@ -0,0 +1,60 @@ +/**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1558: stack check: Support Stack Smashing Protector(SSP)

xiaoxiang781216 commented on a change in pull request #1558: URL: https://github.com/apache/incubator-nuttx/pull/1558#discussion_r468710533 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -31,6 +31,10 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += -O2 -fno-s

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-671988242 > > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. > The break is due to: [apache

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672062434 @patacongo the keep part is > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468705045 ## File path: arch/arm/src/cxd56xx/cxd56_rtc.c ## @@ -254,13 +254,8 @@ static void cxd56_rtc_initialize(int argc, ...) { struct timesp

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468704440 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicate with

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468704147 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicate with

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468703707 ## File path: Documentation/NuttxUserGuide.html ## @@ -10139,7 +10139,6 @@ 2.12.4 shmdt struct tcb_s mqd_t sem_t -WDOG_ID pthread_key_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468702913 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468702785 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672062434 @patacongo the keep part is > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. > > Th

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

hartmannathan commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672057832 On Tue, Aug 11, 2020 at 11:36 AM patacongo wrote: > @btashton @hartmannathan > @Ouss4

[GitHub] [incubator-nuttx] patacongo commented on pull request #1561: Fix in STM32F4 over-drive configuration.

patacongo commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672055511 > This however means that I will have to include `` in `stm32f40xxx_rcc.c`. Is this acceptable, architecturally? Yes, board.h is a "public" header file and may b

[GitHub] [incubator-nuttx] fjpanag commented on pull request #1561: Fix in STM32F4 over-drive configuration.

fjpanag commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672047089 > > I added the option `STM32_HAVE_OVERDRIVE` for all the mentioned MCUs, cleaning things up. > > Now regarding how this feature will be enabled. What do you think is

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468690307 ## File path: arch/arm/src/samv7/sam_ssc.c ## @@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv) static void ssc_dma_f

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468688371 ## File path: arch/arm/src/samv7/sam_ssc.c ## @@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv) static void ssc_dma_f

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672016259 @btashton @hartmannathan @Ouss4 People will need to be forewarned in the release notes that this will break almost all user implementations of drivers. Their c

[GitHub] [incubator-nuttx] davids5 commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

davids5 commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672022055 > @btashton People will need to be forewarned in the release notes that this will break almost all user implementations of drivers. Their code will not longer build and

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468673077 ## File path: arch/arm/src/cxd56xx/cxd56_rtc.c ## @@ -254,13 +254,8 @@ static void cxd56_rtc_initialize(int argc, ...) { struct timespec ts;

[GitHub] [incubator-nuttx] davids5 commented on pull request #1558: stack check: Support Stack Smashing Protector(SSP)

davids5 commented on pull request #1558: URL: https://github.com/apache/incubator-nuttx/pull/1558#issuecomment-672019382 @yamt I am good with this. It can only add value. I will leave this up to you to approve. This is an a

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1558: stack check: Support Stack Smashing Protector(SSP)

davids5 commented on a change in pull request #1558: URL: https://github.com/apache/incubator-nuttx/pull/1558#discussion_r468671011 ## File path: boards/sim/sim/sim/scripts/Make.defs ## @@ -31,6 +31,10 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += -O2 -fno-strict-al

[GitHub] [incubator-nuttx] patacongo commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672016259 @btashton People will need to be forewarned in the release notes that this will break almost all user implementations of drivers. Their code will not longer build and

[GitHub] [incubator-nuttx] davids5 merged pull request #1563: libc/ftw: Fix error: cast between incompatible function types from ftw_cb_t' nftw_cb_t

davids5 merged pull request #1563: URL: https://github.com/apache/incubator-nuttx/pull/1563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated (e0ad381 -> 4df42ba)

This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e0ad381 drivers/rptun: add null-check for 'RPTUN_*' macro. add 4df42ba libc/ftw: Fix error: cast bet

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468658886 ## File path: Documentation/NuttxUserGuide.html ## @@ -10139,7 +10139,6 @@ 2.12.4 shmdt struct tcb_s mqd_t sem_t -WDOG_ID pthread_key_t Rev

[GitHub] [incubator-nuttx] davids5 commented on pull request #1561: Fix in STM32F4 over-drive configuration.

davids5 commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672006224 @fjpanag I set it to Draft. When you are done just un-Draft it This is an automated message from the Apa

[GitHub] [incubator-nuttx] fjpanag commented on pull request #1561: Fix in STM32F4 over-drive configuration.

fjpanag commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672005496 > nice would be able to squash and force push, when you are done? OK, I will do it. Don't merge yet, let's just fix how/when over-drive will be enabled first

[GitHub] [incubator-nuttx] davids5 commented on pull request #1561: Fix in STM32F4 over-drive configuration.

davids5 commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672004966 > I added the option `STM32_HAVE_OVERDRIVE` for all the mentioned MCUs, cleaning things up. > > Now regarding how this feature will be enabled. What do you think i

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-671988242 > > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. > The break is due to: [apache

[GitHub] [incubator-nuttx] davids5 commented on pull request #1561: Fix in STM32F4 over-drive configuration.

davids5 commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672003094 @fjpanag - nice would be able to squash and force push, when you are done? This is an automated message

[GitHub] [incubator-nuttx] fjpanag commented on pull request #1561: Fix in STM32F4 over-drive configuration.

fjpanag commented on pull request #1561: URL: https://github.com/apache/incubator-nuttx/pull/1561#issuecomment-672003048 I added the option `STM32_HAVE_OVERDRIVE` for all the mentioned MCUs, cleaning things up. Now regarding how this feature will be enabled. What do you think is best

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468632963 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicate with

[GitHub] [incubator-nuttx-apps] patacongo opened a new issue #360: Illegal use of wdog timers in FTPC

patacongo opened a new issue #360: URL: https://github.com/apache/incubator-nuttx-apps/issues/360 netutils/ftpc/ftpc_connect.c uses internal OS wdog timer functions wd_start(), wd_cancel(), etc. This is aviolation of the portable POSIX OS interface. wd_start(0 is not an application acce

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

patacongo commented on a change in pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468637397 ## File path: netutils/ftpc/ftpc_connect.c ## @@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session) /* Set up a ti

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

patacongo commented on a change in pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636769 ## File path: netutils/ftpc/ftpc_connect.c ## @@ -214,7 +210,7 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session) fptc_getrepl

[incubator-nuttx] branch master updated (b256b20 -> e0ad381)

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b256b20 Add support to hard links to CROMFS add 2818b6b drivers/rptun: Add 'RPTUN_CONFIG' interf

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1560: Minor fix for rptun driver

Ouss4 merged pull request #1560: URL: https://github.com/apache/incubator-nuttx/pull/1560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

Ouss4 commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468646249 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_t tt

[GitHub] [incubator-nuttx] davids5 merged pull request #1554: Add support for hard links to CROMFS

davids5 merged pull request #1554: URL: https://github.com/apache/incubator-nuttx/pull/1554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated: Add support to hard links to CROMFS

This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b256b20 Add support to hard links to

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

patacongo commented on a change in pull request #357: URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636359 ## File path: netutils/ftpc/ftpc_connect.c ## @@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session) /* Set up a ti

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1554: Add support for hard links to CROMFS

jerpelea commented on pull request #1554: URL: https://github.com/apache/incubator-nuttx/pull/1554#issuecomment-671988292 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] patacongo commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-671988242 > > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. > The break is due to: [apache/incuba

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468633279 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicate with

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

patacongo commented on a change in pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468632963 ## File path: Documentation/NuttxPortingGuide.html ## @@ -2824,100 +2824,13 @@ 4.4.5 Watchdog Timer Interfaces or kill() to communicate with

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

patacongo commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468622371 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

patacongo commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468622371 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

patacongo commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468622371 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

patacongo commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468621366 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-671976809 @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. The break is due to: https://github.co

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1562: arm_createstack.c: Save tcb->adj_stack_size without tls overhead.

patacongo commented on a change in pull request #1562: URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468619696 ## File path: arch/arm/src/common/arm_createstack.c ## @@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t stack_size, uint8_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1545: sched/wdog: Don't dynamically allocate wdog_s

xiaoxiang781216 commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-671976809 @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. ---

  1   2   >