patacongo commented on issue #740:
URL: https://github.com/apache/incubator-nuttx/issues/740#issuecomment-672247919


   > 
   > 
   > @papatience after reviewing all caller of wd_start, all place just need 
one argument so, the prototype can be simple as:
   > 
   > ```
   > typedef CODE void (*wdentry_t)(FAR void *arg);
   > ```
   > 
   > just like what work_s done. If out of tree usage need pass more context 
info, he/she can always allocate the memory as need. So here is the patch: #1565
   
   If arg is the actual, single argument and NOT a pointer to an array of 
arguments, then this seems okay.  But don't use type void *.  There are 
problems using type void * with certain architctures (AVR I think) that was 
fixed by created wdparm_t.  Please continue to use wdparm_t.
   
   Again, I think it is bad engineering judgement to make this change.  Nothing 
is broken, this fixes nothing, and just adds turmoil and additional 
incompatibility to the documented OS internal interfaces.  This is NOT 
responsible engineering.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to