patacongo commented on a change in pull request #1545:
URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468688371
##########
File path: arch/arm/src/samv7/sam_ssc.c
##########
@@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv)
static void ssc_dma_free(struct sam_ssc_s *priv)
{
#ifdef SSC_HAVE_TX
- if (priv->tx.dog)
- {
- wd_delete(priv->tx.dog);
- }
-
+ wd_cancel(&priv->tx.dog);
Review comment:
Are all instances of struct wdog_s properly zeroed? I think there would
be a crash if wd_cancel() were called without at least one wd_start() if the
struct wdog_s is not zeroed(?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
