xiaoxiang781216 edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672062434
@patacongo the keep part is > > @patacongo could you review this patch? I have a pending patch which remove the variadic argument from callback. > > The break is due to: [apache/incubator-nuttx-apps#357](https://github.com/apache/incubator-nuttx-apps/pull/357). If the change looks good, you can merge [apache/incubator-nuttx-apps#357](https://github.com/apache/incubator-nuttx-apps/pull/357) first, and rerun the check for this patch again. > > I am not sure when I will have an opportunity or motivation to review all 662 files. I will try to do a little at a time until I get through them all. I do not work full time on this project these days. I will not be able to complete the review soon. The real change happen inside sched/ and Documentation folder which need you review carefully, others just add & for each wd_xxx and fix nxstyle warning which can be verify by the pre-check system. You can download the patch: https://github.com/apache/incubator-nuttx/pull/1545.diff and review the related change locally. BTW since I split the nxstyle change in another patch, you can just review the patch which make real change from commit tab: https://github.com/apache/incubator-nuttx/pull/1545/commits ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
