xiaoxiang781216 edited a comment on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672162616
> On Tue, Aug 11, 2020 at 11:36 AM patacongo ***@***.***> wrote: @btashton <https://github.com/btashton> @hartmannathan <https://github.com/hartmannathan> @Ouss4 <https://github.com/Ouss4> People will need to be forewarned in the release notes that this will break almost all user implementations of drivers. Their code will not longer build and they will need to make the same code modifications in their product-specific code. Keeping stable interfaces for the user community is a virtue and something we need to take very seriously > Nowhere in this discussion have I seen what is the advantage of this change and/or what problem does it solve, that justifies breaking downstream code, so that we can weigh the advantages vs the disadvantages before merging it. > […](#) If the compatibility is important, wd_create/wd_delete could keep as before. But because the new usage use the less memory, more simple and the conversion is just one line change and be safe(the compiling will fail if forget), I would prefer to encourage people migrate to the new usage and keep the consistence. As dissussion here https://github.com/apache/incubator-nuttx/pull/1517: I will prepare another PR to change the callback from: ``` typedef CODE void (*wdentry_t)(int argc, wdparm_t arg1, ...); ``` to: ``` typedef CODE void (*wdentry_t)(FAR void *arg); ``` This change has no way to avoid the compatibility issue, but is less error prone and generate the fast and compact code. https://github.com/apache/incubator-nuttx/issues/740 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
