xiaoxiang781216 commented on a change in pull request #1545:
URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468805731
##########
File path: arch/arm/src/samv7/sam_ssc.c
##########
@@ -3053,23 +3035,15 @@ static int ssc_dma_allocate(struct sam_ssc_s *priv)
static void ssc_dma_free(struct sam_ssc_s *priv)
{
#ifdef SSC_HAVE_TX
- if (priv->tx.dog)
- {
- wd_delete(priv->tx.dog);
- }
-
+ wd_cancel(&priv->tx.dog);
Review comment:
The usage can be classified as:
1.The first catagory contain both work_s and wdog_s which is safe because
work_s already has the same requirement.
2.The second catagory declare the global variable which will zero by default.
3.The third catagory is dynamically allocated struct which either done by
kmm_malloc/memset or kmm_zalloc.
But after review each wdog_s instance, I found one driver in catagory 3 but
don't zero memory, here is PR:
https://github.com/apache/incubator-nuttx/pull/1564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
