[incubator-doris] 04/20: fix some fe ut failed (#8547)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 1caf8ad3f41d6f1fb3ed15311a9ec38ace6b5333 Author: Zhengguo Yang AuthorDate: Mon Mar 21 10:36:06 2022 +080

[incubator-doris] branch dev-1.0.1 updated (dcf66f2 -> e660dd3)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from dcf66f2 [fix][vectorized] Fix bug of left semi/anti with other join conjunct (#8596) new 2ee49

[incubator-doris] 01/20: [Enhancement](load) speed up stream load for duplicate table, use template for faster get_type_info. (#8500)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2ee49c693f19524bbf44351cada5cdcaaae33004 Author: zbtzbtzbt <35688959+zbtzbt...@users.noreply.github.com>

[incubator-doris] 02/20: [fix] Fix coredump of stddev function (#8543)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit d6be70c13043e42e8f3581cfbe5291b504afc376 Author: HappenLee AuthorDate: Thu Mar 24 11:39:29 2022 +0800

[incubator-doris] 03/20: [improvement] Improve sig handler (#8545)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2e1190b42ed7ce56cfc78017efe2db0e6887863b Author: yiguolei AuthorDate: Tue Mar 22 10:40:31 2022 +0800

[incubator-doris] 12/20: ow num is more accurate than column num in data_types (#8628)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2e46b373c203c945a4e4f27f412e7fa6dcc652ce Author: dataroaring <98214048+dataroar...@users.noreply.github.c

[incubator-doris] 11/20: [fix](vectorization) Vectorization decimal arithmetic inconsistent (#8626)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit d1cf9978702ab60871293bce923a4a7dbe6d9fb9 Author: wangbo AuthorDate: Mon Mar 28 10:12:39 2022 +0800

[incubator-doris] 06/20: [fix][vectorized] fix core on get_predicate_column_ptr && fix double copy on _read_columns_by_rowids (#8581)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 9861c3c028165fe913bf1f804e8a538b6ffa3800 Author: Pxl <952130...@qq.com> AuthorDate: Thu Mar 24 09:12:42 2

[incubator-doris] 05/20: [api-change] add soft limit of String type length (#8567)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 11374d67b2195d24778657b2b29cbbe1b2b2c395 Author: Zhengguo Yang AuthorDate: Fri Mar 25 09:28:41 2022 +080

[incubator-doris] 07/20: [fix](load) fix another bug that BE may crash when calling `mark_as_failed` (#8607)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit a06844719fc4de71eba35d52e6e786e5c5308902 Author: Mingyu Chen AuthorDate: Thu Mar 24 09:13:54 2022 +0800

[incubator-doris] 13/20: [chore] optimize aws thirdparty package download. (#8637)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 035006fb6cded49014be8b566b3e4998078b176d Author: Zhengguo Yang AuthorDate: Mon Mar 28 09:35:51 2022 +080

[incubator-doris] 16/20: [fix](mini-load) Remove mini load in LOADING and PENDING state (#8649)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 2e1e2b308fd27c809708de269a28495546bc9049 Author: Mingyu Chen AuthorDate: Mon Mar 28 10:22:17 2022 +0800

[incubator-doris] 10/20: [fix](load) Fix null column bug in load's mapping column setting (#8625)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit ca1974f9bd4da10986480321ae22310b05a62915 Author: HB <137497...@qq.com> AuthorDate: Mon Mar 28 10:08:00 20

[incubator-doris] 15/20: [chore] add -rtlib=compiler-rt for UBSAN under clang (#8647)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 6e6ba618b1d11c595808cf1ad1412aaf894137be Author: dataroaring <98214048+dataroar...@users.noreply.github.c

[incubator-doris] 08/20: [doc] fix typo for session (#8610)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 84331c8f472ffba897f5670308a4c0a83145f703 Author: GoGoWen <82132356+gogo...@users.noreply.github.com> Auth

[incubator-doris] 17/20: [chore] Optimize build_lz4 in build-thirdparty.sh (#8653)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit c492f418a5e82734383feeb425d7d029a660e0e3 Author: Adonis Ling AuthorDate: Mon Mar 28 10:24:32 2022 +0800

[incubator-doris] 09/20: [doc] fix help module failed (#8617)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 07cc83736bad3fd75bcb8afdfb5c2e52ecc07be5 Author: qiye AuthorDate: Thu Mar 24 09:15:06 2022 +0800 [d

[incubator-doris] 14/20: [fix](vec) fix coredump for aggregate function when delete large_data, due to alloc-dealloc-mismatch (#8641)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit d532aad9639bf8e022bf918a38b23ba7a18c7604 Author: airborne12 AuthorDate: Mon Mar 28 10:17:13 2022 +0800

[incubator-doris] 18/20: [doc] update doc of vec-execution-engine (#8655)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 0d9d7863e3776ff7ea296f2a861b9c035e417688 Author: zbtzbtzbt <35688959+zbtzbt...@users.noreply.github.com>

[incubator-doris] 19/20: [Refactor] Remove ununsed file (#8657)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 535e5744003ce24232fd4bdc72e41454a8af9095 Author: Pxl <952130...@qq.com> AuthorDate: Sun Mar 27 01:41:06 2

[incubator-doris] 20/20: [fix] fix core dump when avg on not null decimal in empty table (#8681)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch dev-1.0.1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit e660dd323c5dfbb1198c429cd368be3b299aa235 Author: dataroaring <98214048+dataroar...@users.noreply.github.c

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8660: [Vectorized][refactor] refactor stddev/variance agg functions

2022-03-28 Thread GitBox
HappenLee commented on a change in pull request #8660: URL: https://github.com/apache/incubator-doris/pull/8660#discussion_r836116818 ## File path: be/src/vec/aggregate_functions/aggregate_function_stddev.h ## @@ -296,4 +287,21 @@ class AggregateFunctionStddevSamp final }

[GitHub] [incubator-doris] yiguolei opened a new pull request #8694: Remove mem tablet from be

2022-03-28 Thread GitBox
yiguolei opened a new pull request #8694: URL: https://github.com/apache/incubator-doris/pull/8694 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavi

[incubator-doris] branch stream-load-vec created (now 365eba0)

2022-03-28 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch stream-load-vec in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 365eba0 [fix] fix core dump when avg on not null decimal in empty table (#8681) No new revis

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8572: [Vectorized][Bug] fix percentile_approx function to return always nullable

2022-03-28 Thread GitBox
HappenLee commented on a change in pull request #8572: URL: https://github.com/apache/incubator-doris/pull/8572#discussion_r836114439 ## File path: be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h ## @@ -152,32 +166,86 @@ class AggregateFunctionPercentileAp

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8572: [Vectorized][Bug] fix percentile_approx function to return always nullable

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8572: URL: https://github.com/apache/incubator-doris/pull/8572#issuecomment-1080292911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8642: [Enhancement] add clang-tidy config && add C++ Code Diagnostic document

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8642: URL: https://github.com/apache/incubator-doris/pull/8642#issuecomment-1080301617 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] morrySnow opened a new pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow opened a new pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695 # Proposed changes broadcast join cost is used compressed data size currently. The amount of memory used may be significantly more than estimated. This patch 1. add a compresse

[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #8694: Remove mem tablet from be

2022-03-28 Thread GitBox
zbtzbtzbt commented on pull request #8694: URL: https://github.com/apache/incubator-doris/pull/8694#issuecomment-1080351400 6 6 6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8694: [refactor]Remove mem tablet from be

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8694: URL: https://github.com/apache/incubator-doris/pull/8694#issuecomment-1080377500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] emerkfu opened a new pull request #8696: [doc] Update flink-doris-connector.md

2022-03-28 Thread GitBox
emerkfu opened a new pull request #8696: URL: https://github.com/apache/incubator-doris/pull/8696 # Proposed changes 1. Added the required Flink dependencies for flink-doris-connector. 2. Document format and name case modification. ## Problem Summary: 1. There is no descripti

[GitHub] [incubator-doris] yiguolei commented on pull request #8693: [refactor] remove `atomic.h/cpp` use std::atomic instead

2022-03-28 Thread GitBox
yiguolei commented on pull request #8693: URL: https://github.com/apache/incubator-doris/pull/8693#issuecomment-1080381807 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #8693: [refactor] remove `atomic.h/cpp` use std::atomic instead

2022-03-28 Thread GitBox
zbtzbtzbt commented on pull request #8693: URL: https://github.com/apache/incubator-doris/pull/8693#issuecomment-1080385301 I have a small question: why some variables are initialized to 0 and some not -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] luzhijing commented on pull request #8696: [doc] Update flink-doris-connector.md

2022-03-28 Thread GitBox
luzhijing commented on pull request #8696: URL: https://github.com/apache/incubator-doris/pull/8696#issuecomment-1080398613 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8696: [doc] Update flink-doris-connector.md

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8696: URL: https://github.com/apache/incubator-doris/pull/8696#issuecomment-1080398695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836220463 ## File path: be/src/olap/null_predicate.cpp ## @@ -29,6 +29,13 @@ namespace doris { NullPredicate::NullPredicate(uint32_t column_id, bool is_null

[GitHub] [incubator-doris] yangzhg commented on pull request #8693: [refactor] remove `atomic.h/cpp` use std::atomic instead

2022-03-28 Thread GitBox
yangzhg commented on pull request #8693: URL: https://github.com/apache/incubator-doris/pull/8693#issuecomment-1080401312 > I have a small question: why some variables are initialized to 0 and some not Previous `AtomicInt` will initialize value as `0`, but `std::atomic` not, the va

[GitHub] [incubator-doris] adonis0147 closed issue #8687: [Bug] Failed to build be.

2022-03-28 Thread GitBox
adonis0147 closed issue #8687: URL: https://github.com/apache/incubator-doris/issues/8687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
EmmyMiao87 commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080408707 Why add a memory control to limit the broadcast memory? Instead of using mem limit uniformly? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836228572 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -264,127 +261,121 @@ class ColumnDictionary final : public COWHelper> { ColumnPt

[GitHub] [incubator-doris] huangyuansheng opened a new issue #8697: [Bug] About full join and cross join

2022-03-28 Thread GitBox
huangyuansheng opened a new issue #8697: URL: https://github.com/apache/incubator-doris/issues/8697 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version

[GitHub] [incubator-doris] huangyuansheng opened a new issue #8698: [Bug] About grouping sets

2022-03-28 Thread GitBox
huangyuansheng opened a new issue #8698: URL: https://github.com/apache/incubator-doris/issues/8698 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version

[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #8693: [refactor] remove `atomic.h/cpp` use std::atomic instead

2022-03-28 Thread GitBox
zbtzbtzbt commented on pull request #8693: URL: https://github.com/apache/incubator-doris/pull/8693#issuecomment-1080430760 > the variables not initialize as 0 will be initialized at ctor i get it, thanks -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
zenoyang commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836242857 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -264,127 +261,121 @@ class ColumnDictionary final : public COWHelper> { Column

[GitHub] [incubator-doris] huangyuansheng opened a new issue #8699: [Bug] non-partitioned need to check partition expr

2022-03-28 Thread GitBox
huangyuansheng opened a new issue #8699: URL: https://github.com/apache/incubator-doris/issues/8699 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836248638 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -264,127 +261,121 @@ class ColumnDictionary final : public COWHelper> { ColumnPt

[GitHub] [incubator-doris] dataalive opened a new issue #8700: [Enhancement] show brokers instant of show broker

2022-03-28 Thread GitBox
dataalive opened a new issue #8700: URL: https://github.com/apache/incubator-doris/issues/8700 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
zenoyang commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836253005 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -264,127 +261,121 @@ class ColumnDictionary final : public COWHelper> { Column

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836253588 ## File path: be/src/olap/column_predicate.h ## @@ -33,13 +33,30 @@ class VectorizedRowBatch; class Schema; class RowBlockV2; +enum class Predi

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836253588 ## File path: be/src/olap/column_predicate.h ## @@ -33,13 +33,30 @@ class VectorizedRowBatch; class Schema; class RowBlockV2; +enum class Predi

[GitHub] [incubator-doris] hf200012 opened a new pull request #8701: [Improve]Remove http v1 code and disable mini load by default

2022-03-28 Thread GitBox
hf200012 opened a new pull request #8701: URL: https://github.com/apache/incubator-doris/pull/8701 1. http v2 has been actually tested in production, and it is completely replaceable to have http code. In order to simplify code maintenance, remove the previous http part of the code 2. T

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8597: [feature-wip](array-type)Add element_at and subscript functions

2022-03-28 Thread GitBox
HappenLee commented on a change in pull request #8597: URL: https://github.com/apache/incubator-doris/pull/8597#discussion_r836141107 ## File path: be/src/vec/functions/array/function_array_index.h ## @@ -126,21 +139,37 @@ class FunctionArrayIndex : public IFunction re

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
zenoyang commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836261018 ## File path: be/src/olap/column_predicate.h ## @@ -33,13 +33,30 @@ class VectorizedRowBatch; class Schema; class RowBlockV2; +enum class Pre

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
zenoyang commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836261369 ## File path: be/src/vec/columns/column_dictionary.h ## @@ -264,127 +261,121 @@ class ColumnDictionary final : public COWHelper> { Column

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #8702: [typo] Fix runtime filter docs

2022-03-28 Thread GitBox
EmmyMiao87 opened a new pull request #8702: URL: https://github.com/apache/incubator-doris/pull/8702 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8702: [typo] Fix runtime filter docs

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8702: URL: https://github.com/apache/incubator-doris/pull/8702#issuecomment-1080466337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8532: [feature](cold-hot) support remote storage

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8532: URL: https://github.com/apache/incubator-doris/pull/8532#issuecomment-1080472729 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] emerkfu opened a new pull request #8703: [doc] Update VARCHAR.md

2022-03-28 Thread GitBox
emerkfu opened a new pull request #8703: URL: https://github.com/apache/incubator-doris/pull/8703 # Proposed changes Added explicit description of 'M' in VARCHAR(M). ## Problem Summary: The meaning of 'M' may be mixed with bytes or characters, here it is clarified that the mean

[GitHub] [incubator-doris] morningman commented on a change in pull request #8663: Support remote storage, step2, only for be, add env_remote_mgr

2022-03-28 Thread GitBox
morningman commented on a change in pull request #8663: URL: https://github.com/apache/incubator-doris/pull/8663#discussion_r836164163 ## File path: gensrc/thrift/HeartbeatService.thrift ## @@ -32,6 +33,7 @@ struct TMasterInfo { 6: optional Types.TPort http_port 7: op

[GitHub] [incubator-doris] wangbo commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
wangbo commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836305968 ## File path: be/src/olap/comparison_predicate.cpp ## @@ -159,60 +159,54 @@ COMPARISON_PRED_COLUMN_BLOCK_EVALUATE(GreaterEqualPredicate, >=)

[GitHub] [incubator-doris] morningman opened a new issue #8704: [Bug] routine load return too many task error

2022-03-28 Thread GitBox
morningman opened a new issue #8704: URL: https://github.com/apache/incubator-doris/issues/8704 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version mas

[GitHub] [incubator-doris] morningman opened a new pull request #8705: [fix](load) fix bug that NodeChannel can not be destroyed ontime

2022-03-28 Thread GitBox
morningman opened a new pull request #8705: URL: https://github.com/apache/incubator-doris/pull/8705 # Proposed changes Issue Number: close #8704 ## Problem Summary: After the ReusableClosure is reset, we can not call join() method, or it will blocked forever. #

[GitHub] [incubator-doris] morningman commented on a change in pull request #8705: [fix](load) fix bug that NodeChannel can not be destroyed ontime

2022-03-28 Thread GitBox
morningman commented on a change in pull request #8705: URL: https://github.com/apache/incubator-doris/pull/8705#discussion_r836309355 ## File path: be/src/exec/tablet_sink.cpp ## @@ -504,7 +504,6 @@ void NodeChannel::try_send_batch(RuntimeState* state) { } } -

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8705: [fix](load) fix bug that NodeChannel can not be destroyed ontime

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8705: URL: https://github.com/apache/incubator-doris/pull/8705#issuecomment-1080513523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-28 Thread GitBox
caiconghui commented on a change in pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#discussion_r836319606 ## File path: be/src/olap/rowset/segment_v2/indexed_column_reader.cpp ## @@ -31,12 +31,12 @@ Status IndexedColumnReader::load(bool use_page_cac

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-28 Thread GitBox
caiconghui commented on a change in pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#discussion_r836319780 ## File path: be/src/olap/tablet_schema.cpp ## @@ -286,7 +286,7 @@ TabletColumn::TabletColumn(FieldAggregationMethod agg, FieldType type) { T

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-28 Thread GitBox
caiconghui commented on a change in pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#discussion_r836320044 ## File path: be/src/olap/column_vector.h ## @@ -150,7 +150,7 @@ class ScalarColumnVectorBatch : public ColumnVectorBatch { class ArrayNullCol

[GitHub] [incubator-doris] chenlinzhong commented on a change in pull request #8604: [Feature] CSV import and export support header

2022-03-28 Thread GitBox
chenlinzhong commented on a change in pull request #8604: URL: https://github.com/apache/incubator-doris/pull/8604#discussion_r836322875 ## File path: gensrc/thrift/PlanNodes.thrift ## @@ -108,6 +108,22 @@ enum TFileFormatType { FORMAT_ORC, FORMAT_JSON, FORMAT_PR

[GitHub] [incubator-doris] spaces-X opened a new pull request #8706: [Enhancement] add switch of quantile_state column

2022-03-28 Thread GitBox
spaces-X opened a new pull request #8706: URL: https://github.com/apache/incubator-doris/pull/8706 # Proposed changes Add switch for quantile_state column, default false. ## Problem Summary: ## Checklist(Required) 1. Does it affect the original behavior: (No)

[GitHub] [incubator-doris] morningman commented on pull request #8683: optimize create tpch table statments to achieve higher performance

2022-03-28 Thread GitBox
morningman commented on pull request #8683: URL: https://github.com/apache/incubator-doris/pull/8683#issuecomment-1080531532 > Can you provide some performance changes and conclusions before and after the table conversion? I think this may trigger some bucket shuffle join -- This

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8668: [Bug][Vectorized] fix core dump with HLL and some refactor of Decompressor

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8668: URL: https://github.com/apache/incubator-doris/pull/8668#issuecomment-1080531428 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
zenoyang commented on a change in pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836325169 ## File path: be/src/olap/comparison_predicate.cpp ## @@ -159,60 +159,54 @@ COMPARISON_PRED_COLUMN_BLOCK_EVALUATE(GreaterEqualPredicate, >=)

[GitHub] [incubator-doris] spaces-X commented on pull request #8706: [Enhancement] add switch of quantile_state column

2022-03-28 Thread GitBox
spaces-X commented on pull request #8706: URL: https://github.com/apache/incubator-doris/pull/8706#issuecomment-1080534118 @wangbo Add a switch of `quantile_state` column to ensure stability, and it will be removed after subsequent tests are stable -- This is an automated message from t

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8683: optimize create tpch table statments to achieve higher performance

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8683: URL: https://github.com/apache/incubator-doris/pull/8683#issuecomment-1080536016 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8627: [refactor][optimize] Code optimization and refactoring for low-cardinality columns in storage layer

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8627: URL: https://github.com/apache/incubator-doris/pull/8627#issuecomment-1080537851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] morrySnow commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080544250 > Why add a memory control to limit the broadcast memory? Instead of using mem limit uniformly? there are 2 reason: 1. broadcast is not always fast than

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8706: [Enhancement] add switch of quantile_state column

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8706: URL: https://github.com/apache/incubator-doris/pull/8706#issuecomment-1080546759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] cambyzju commented on a change in pull request #8597: [feature-wip](array-type)Add element_at and subscript functions

2022-03-28 Thread GitBox
cambyzju commented on a change in pull request #8597: URL: https://github.com/apache/incubator-doris/pull/8597#discussion_r836337237 ## File path: be/src/vec/functions/array/function_array_index.h ## @@ -126,21 +139,37 @@ class FunctionArrayIndex : public IFunction ret

[GitHub] [incubator-doris] HappenLee commented on pull request #8597: [feature-wip](array-type)Add element_at and subscript functions

2022-03-28 Thread GitBox
HappenLee commented on pull request #8597: URL: https://github.com/apache/incubator-doris/pull/8597#issuecomment-1080551003 Check the logic of Clickhouse 1. array_string call `array_position` with `int` param 2. array_float call `array_position` with `int` param Confirm the behav

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8703: [doc] Update VARCHAR.md

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8703: URL: https://github.com/apache/incubator-doris/pull/8703#issuecomment-1080552101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836226913 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableS

[GitHub] [incubator-doris] cambyzju commented on pull request #8597: [feature-wip](array-type)Add element_at and subscript functions

2022-03-28 Thread GitBox
cambyzju commented on pull request #8597: URL: https://github.com/apache/incubator-doris/pull/8597#issuecomment-1080555999 > Check the logic of Clickhouse > > 1. array_string call `array_position` with `int` param > 2. array_float call `array_position` with `int` param >C

[GitHub] [incubator-doris] dataroaring opened a new pull request #8707: remove useless code in DataTypeDecimal

2022-03-28 Thread GitBox
dataroaring opened a new pull request #8707: URL: https://github.com/apache/incubator-doris/pull/8707 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beh

[GitHub] [incubator-doris] morrySnow commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836352339 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSp

[GitHub] [incubator-doris] dataroaring opened a new pull request #8708: comment code convering decimal format

2022-03-28 Thread GitBox
dataroaring opened a new pull request #8708: URL: https://github.com/apache/incubator-doris/pull/8708 The comment can help newbies read code mouch more quickly. # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes.

[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
EmmyMiao87 commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080575928 Adding a session variable is more difficult for users to understand. The intuitive way is to add hint after join -- This is an automated message

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836367645 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableS

[GitHub] [incubator-doris] xinyiZzz commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
xinyiZzz commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080590449 > > Why add a memory control to limit the broadcast memory? Instead of using mem limit uniformly? > > there are 2 reason: > > 1. broadcast is not always f

[GitHub] [incubator-doris] jacktengg opened a new pull request #8709: Stream load

2022-03-28 Thread GitBox
jacktengg opened a new pull request #8709: URL: https://github.com/apache/incubator-doris/pull/8709 # Proposed changes Issue Number: close #xxx ## Problem Summary: Implement vectorized stream load. Added fe and be configuration option enable_vectorized_load to enable ve

[GitHub] [incubator-doris] morningman opened a new pull request #8710: [fix](user-property) Fix bug that can not set exec_mem_limit at user level

2022-03-28 Thread GitBox
morningman opened a new pull request #8710: URL: https://github.com/apache/incubator-doris/pull/8710 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original beha

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
xinyiZzz commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836383494 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSpa

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
xinyiZzz commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836383494 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSpa

[GitHub] [incubator-doris] caiconghui commented on pull request #8680: [Refactor](type_info) use template and single instance to refactor get type info logic

2022-03-28 Thread GitBox
caiconghui commented on pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#issuecomment-1080601888 > for some certainly types, I think all use unified `_typeinfo` do not reflect semantics, such as `bf_typeinfo` is better than `_typeinfo`. we may can modify some ce

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8710: [fix](user-property) Fix bug that can not set exec_mem_limit at user level

2022-03-28 Thread GitBox
github-actions[bot] commented on pull request #8710: URL: https://github.com/apache/incubator-doris/pull/8710#issuecomment-1080602840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] tianhui5 opened a new pull request #8711: [Feature] Support load binlog from MySQL directly instead of Canal (#8025)

2022-03-28 Thread GitBox
tianhui5 opened a new pull request #8711: URL: https://github.com/apache/incubator-doris/pull/8711 # Proposed changes Issue Number: close #8025 ## Problem Summary: ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been adde

[GitHub] [incubator-doris] xinyiZzz commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
xinyiZzz commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080610064 Increasing the compression ratio is a good attempt~, do you have verification accuracy there. In #6274, I have compared the calculated broadcast cost to the actu

[GitHub] [incubator-doris] morrySnow commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836413449 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSp

[GitHub] [incubator-doris] morrySnow commented on a change in pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on a change in pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r836413666 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java ## @@ -147,7 +149,7 @@ public long constructHashTableSp

[GitHub] [incubator-doris] morrySnow commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080633638 > Adding a session variable is more difficult for users to understand. The intuitive way is to add hint after join i don't think so. It is common that query sub

[GitHub] [incubator-doris] morrySnow commented on pull request #8695: [enhancement] update broadcast join cost algorithm

2022-03-28 Thread GitBox
morrySnow commented on pull request #8695: URL: https://github.com/apache/incubator-doris/pull/8695#issuecomment-1080649337 > > > Why add a memory control to limit the broadcast memory? Instead of using mem limit uniformly? > > > > > > there are 2 reason: > > > > 1. broadc

  1   2   >