zenoyang commented on a change in pull request #8627:
URL: https://github.com/apache/incubator-doris/pull/8627#discussion_r836253005
##########
File path: be/src/vec/columns/column_dictionary.h
##########
@@ -264,127 +261,121 @@ class ColumnDictionary final : public
COWHelper<IColumn, ColumnDictionary<T>> {
ColumnPtr convert_to_predicate_column() {
auto res = vectorized::PredicateColumnType<StringValue>::create();
- size_t size = codes.size();
+ size_t size = _codes.size();
res->reserve(size);
for (size_t i = 0; i < size; ++i) {
- auto& code = reinterpret_cast<T&>(codes[i]);
- auto value = dict.get_value(code);
+ auto& code = reinterpret_cast<T&>(_codes[i]);
+ auto value = _dict.get_value(code);
res->insert_data(value.ptr, value.len);
}
- dict.clear();
+ _dict.clear();
return res;
}
- void convert_dict_codes() {
- if (!is_dict_sorted()) {
- sort_dict();
- }
-
- if (!is_dict_code_converted()) {
- for (size_t i = 0; i < size(); ++i) {
- codes[i] = dict.convert_code(codes[i]);
- }
- _dict_code_converted = true;
+ ColumnPtr convert_to_predicate_column_if_dictionary() override {
+ auto res = vectorized::PredicateColumnType<StringValue>::create();
Review comment:
No difference, `convert_to_predicate_column` is useless, I'll delete it
right away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
