chenlinzhong commented on a change in pull request #8604: URL: https://github.com/apache/incubator-doris/pull/8604#discussion_r836322875
########## File path: gensrc/thrift/PlanNodes.thrift ########## @@ -108,6 +108,22 @@ enum TFileFormatType { FORMAT_ORC, FORMAT_JSON, FORMAT_PROTO, + //csv withnames + FORMAT_CSVWITHNAMES_PLAIN, Review comment: Yes, the more reasonable way is to enumerate the file type and compression type separately. However, since the previous logic is that the two are put together, the expansibility is not very good. If you want to separate them, there are many changes involved and the cycle will be relatively long. Therefore, the previous way is still temporarily continued here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org