This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git

commit d532aad9639bf8e022bf918a38b23ba7a18c7604
Author: airborne12 <airborn...@gmail.com>
AuthorDate: Mon Mar 28 10:17:13 2022 +0800

    [fix](vec) fix coredump for aggregate function when delete large_data, due 
to alloc-dealloc-mismatch (#8641)
---
 be/src/vec/aggregate_functions/aggregate_function_min_max.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/be/src/vec/aggregate_functions/aggregate_function_min_max.h 
b/be/src/vec/aggregate_functions/aggregate_function_min_max.h
index 2b769e5..26fd57e 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_min_max.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_min_max.h
@@ -225,7 +225,7 @@ private:
     char small_data[MAX_SMALL_STRING_SIZE]; /// Including the terminating zero.
 
 public:
-    ~SingleValueDataString() { delete large_data; }
+    ~SingleValueDataString() { delete[] large_data; }
 
     bool has() const { return size >= 0; }
 
@@ -242,7 +242,7 @@ public:
         if (size != -1) {
             size = -1;
             capacity = 0;
-            delete large_data;
+            delete[] large_data;
             large_data = nullptr;
         }
     }
@@ -266,7 +266,7 @@ public:
             } else {
                 if (capacity < rhs_size) {
                     capacity = 
static_cast<UInt32>(round_up_to_power_of_two_or_zero(rhs_size));
-                    delete large_data;
+                    delete[] large_data;
                     large_data = new char[capacity];
                 }
 
@@ -296,7 +296,7 @@ public:
             if (capacity < value_size) {
                 /// Don't free large_data here.
                 capacity = round_up_to_power_of_two_or_zero(value_size);
-                delete large_data;
+                delete[] large_data;
                 large_data = new char[capacity];
             }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to