morningman commented on a change in pull request #8705: URL: https://github.com/apache/incubator-doris/pull/8705#discussion_r836309355
########## File path: be/src/exec/tablet_sink.cpp ########## @@ -504,7 +504,6 @@ void NodeChannel::try_send_batch(RuntimeState* state) { } } - _add_batch_closure->reset(); Review comment: For reviewer: if call reset() here, the cancel() may be called after it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org