HappenLee commented on a change in pull request #8660:
URL: https://github.com/apache/incubator-doris/pull/8660#discussion_r836116818
##########
File path: be/src/vec/aggregate_functions/aggregate_function_stddev.h
##########
@@ -296,4 +287,21 @@ class AggregateFunctionStddevSamp final
}
};
+//samp function it's always nullables, it's need to handle nullable column
+//so return type and add function should processing null values
+template <typename Data, bool is_nullable>
+class AggregateFunctionSamp : public AggregateFunctionSampVariance<false,
Data, is_nullable> {
Review comment:
use `final` inherit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
