start one.
Anthony
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 1:38 PM
> To: Anthony Xu
> Cc: 'David Nalley'; cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Adva
On Fri, Feb 08, 2013 at 01:27:46PM -0800, Anthony Xu wrote:
> So we changed the criteria for merge, should we post a formal document for
> the criteria? In case someone is not aware of that.
I'm not sure if we have *any* formal document somewhere, but that's a
good idea! Do you want to start one
> Cc: 'David Nalley'; cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Fri, Feb 08, 2013 at 12:42:17PM -0800, Anthony Xu wrote:
> > CloudStack has plug-in framework to add different devices to
> > CloudStack, mos
On Fri, Feb 08, 2013 at 12:42:17PM -0800, Anthony Xu wrote:
> CloudStack has plug-in framework to add different devices to
> CloudStack, most of the code should be done in new java files.
> But they need to add a new API to add the device to CloudStack,
> this new API may cross several managers,
unit test for those
managers may scare them away.
Anthony
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Friday, February 08, 2013 12:35 PM
> To: Anthony Xu
> Cc: Chip Childers; cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE]
On Fri, Feb 08, 2013 at 12:32:57PM -0800, Anthony Xu wrote:
> My point is adding unit test for existing java file should be separate task,
> it should not block developers to change java file. As I said before, we
> should file a bug for each java file which doesn't have unit test, and
> arrange
On Fri, Feb 8, 2013 at 3:32 PM, Anthony Xu wrote:
> My point is adding unit test for existing java file should be separate task,
> it should not block developers to change java file. As I said before, we
> should file a bug for each java file which doesn't have unit test, and
> arrange resource
Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 12:19 PM
> To: Anthony Xu
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Fri, Feb 08, 2013 at 11:43:52AM -0800, Ant
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 12:19 PM
> To: Anthony Xu
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Fri, Feb 08,
On Fri, Feb 08, 2013 at 11:43:52AM -0800, Anthony Xu wrote:
> I see your point, I think it should be case by case,
>
> In this feature, 100 line change are in 6 "manager" class, there is no unit
> framework for them, to be honest, I don't know to create the unit framework
> for manager class, I
On Fri, Feb 8, 2013 at 2:43 PM, Anthony Xu wrote:
> I see your point, I think it should be case by case,
>
> In this feature, 100 line change are in 6 "manager" class, there is no unit
> framework for them, to be honest, I don't know to create the unit framework
> for manager class, I believe it
e, what's the next step? Call for vote, or Call for review?
Thanks,
Anthony
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 11:20 AM
> To: Anthony Xu
> Cc: cloudstack-dev@incubator.apache.org
> Subjec
On Fri, Feb 08, 2013 at 11:04:09AM -0800, Anthony Xu wrote:
> But it is unfair developer should write a complete unit test for class if the
> unit test doesn't exist and he modifies the class, because he may not
> understand class well, he may not be able to write a unit test for the class.
That
m: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 10:32 AM
> To: Anthony Xu
> Cc: cloudstack-dev@incubator.apache.org
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Fri, Feb 08, 2013 at 10:20:45AM -0800, Anthony Xu wrote:
> >
On Fri, Feb 08, 2013 at 10:21:49AM -0800, Alex Huang wrote:
> Chip,
>
> I support what you're saying here but want to offer up a compromise in the
> process to lessen the work. I'm sure Anthony will want to add unit tests.
> How about
>
> - We file a bug for unit tests for 4.2.
> - Add the c
On Fri, Feb 08, 2013 at 10:20:45AM -0800, Anthony Xu wrote:
> Sorry, I missed your first email, I'll revert the commits soon.
>
> I have following questions here,
> -What's the criteria when unit test is needed, take this as an example, these
> commits changed two API behaviors, CreateVlanIpRange
Anthony Xu
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Tue, Feb 5, 2013 at 2:20 PM, Chip Childers
> wrote:
> > On Tue, Feb 05, 2013 at 10:50:17AM -0800, Anthony Xu wrote:
> >> I would like to request merge of feature " security group in advanced
rs [mailto:chip.child...@sungard.com]
> Sent: Friday, February 08, 2013 7:48 AM
> To: cloudstack-dev@incubator.apache.org; Anthony Xu
> Subject: Re: [MERGE] Security Group in Advanced zone
>
> On Tue, Feb 5, 2013 at 2:20 PM, Chip Childers
> wrote:
> > On Tue, Feb 05, 2013
On Tue, Feb 5, 2013 at 2:20 PM, Chip Childers wrote:
> On Tue, Feb 05, 2013 at 10:50:17AM -0800, Anthony Xu wrote:
>> I would like to request merge of feature " security group in advanced zone"
>>
>
> The latest update in the Jira record states that it's 70% complete.
>
> Also, the branch (sg-in-a
On Tue, Feb 05, 2013 at 10:50:17AM -0800, Anthony Xu wrote:
> I would like to request merge of feature " security group in advanced zone"
>
The latest update in the Jira record states that it's 70% complete.
Also, the branch (sg-in-advanced-zone) seems to be quite different from
the current stat
20 matches
Mail list logo
