So we changed the criteria for merge, should we post a formal document for the criteria? In case someone is not aware of that.
Anthony > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, February 08, 2013 12:52 PM > To: Anthony Xu > Cc: 'David Nalley'; cloudstack-dev@incubator.apache.org > Subject: Re: [MERGE] Security Group in Advanced zone > > On Fri, Feb 08, 2013 at 12:42:17PM -0800, Anthony Xu wrote: > > CloudStack has plug-in framework to add different devices to > > CloudStack, most of the code should be done in new java files. > > But they need to add a new API to add the device to CloudStack, > > this new API may cross several managers, if there is no unit > > test for those managers, requiring them to add unit test for > > those managers may scare them away. > > > > Anthony > > It may, which is another reason to get on with fixing it. > > -chip