It doesn't explicitly say anything about writing unit test for existing java file modification when do merge. To make everyone feel fair, we should have a criteria we can stick to. Since you've been monitoring the merge/ check in, you may know better what criteria it should be, please start one.
Anthony > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, February 08, 2013 1:38 PM > To: Anthony Xu > Cc: 'David Nalley'; cloudstack-dev@incubator.apache.org > Subject: Re: [MERGE] Security Group in Advanced zone > > On Fri, Feb 08, 2013 at 01:27:46PM -0800, Anthony Xu wrote: > > So we changed the criteria for merge, should we post a formal > document for the criteria? In case someone is not aware of that. > > I'm not sure if we have *any* formal document somewhere, but that's a > good idea! Do you want to start one? Or is there something that I'm > not remembering (which would be great to be reminded of)? > > We have certainly had discussions about this in the past, see [1] and > [2] for some examples. > > -chip > > [1] http://markmail.org/thread/s56ye76nohd23qir > [2] http://markmail.org/message/df7npjqrepaqpv2j
