Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
On 8/3/12 7:40 PM, "Tomoe Sugihara" wrote: > > >> On Aug. 3, 2012, 10:31 p.m., Chiradeep Vittal wrote: >> > >>plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBrid >>geVifDriver.java, line 49 >> > >> >

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
On 8/3/12 7:29 PM, "Tomoe Sugihara" wrote: > > >> On Aug. 3, 2012, 10:03 p.m., Chiradeep Vittal wrote: >> > >>plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifD >>river.java, line 35 >> > >> >> > >>

Re: ec2 API compatibility (WSDL vs Query)

2012-08-03 Thread Adrian Cole
Thanks! I look forward to it. -A On Aug 3, 2012 6:45 PM, "David Nalley" wrote: > On Fri, Aug 3, 2012 at 7:55 PM, Adrian Cole > wrote: > > Certainly, a public endpoint is easier on devs than a work-in-progress > > devstack. I'm not sure I will have time to work through that process in > > the s

Re: AWSAPI dependencies

2012-08-03 Thread David Nalley
On Thu, Aug 2, 2012 at 7:45 PM, Prachi Damle wrote: > There is a version difference for the axis framework used - awsapi uses axis2 > while some CloudStack component is built using earlier version 1.4. > And it was also the simplest way to integrate without needing the build > scripts to change

Re: Regarding Runbook and L10N

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 5:54 AM, Mice Xia wrote: > Hi, all > > As I was working on Chinese version of Runbook [1], I found some pieces of > original document need to be updated. > > In chapter Configuration: > - Pod Configuration > This section consists of both pod setup and guest network setup, b

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:31 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java, > > line 49 > > > > > > This should not be a concern of the vif drive

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Tomoe Sugihara
> On Aug. 3, 2012, 10:03 p.m., Chiradeep Vittal wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifDriver.java, > > line 35 > > > > > > This should be an Interface rather than an abstract

RE: where features are developed was: Review Request: Merge Kelven's VPC code for Vmware into asf vpc branch

2012-08-03 Thread Ewan Mellor
> -Original Message- > From: Brett Porter [mailto:br...@porterclan.net] On Behalf Of Brett Porter > > [Snip] > > > > > However, we do need to work out a process for accepting changesets with > multiple authors. It is very normal for two people to work on something and > for this to turn in

RE: CloudStack Events Plans

2012-08-03 Thread Ewan Mellor
XenSummit is co-located with CloudOpen this time, on the Monday-Tuesday that week. I'll be speaking about the use of Xen under CloudStack. I'll be at CloudOpen afterwards, of course. If there's anyone out there who wants to come to XenSummit, then I'm sure we can make room. Cheers, Ewan. >

Re: ec2 API compatibility (WSDL vs Query)

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 7:55 PM, Adrian Cole wrote: > Certainly, a public endpoint is easier on devs than a work-in-progress > devstack. I'm not sure I will have time to work through that process in > the short term. I am happy to help test an existing endpoint and maintain > tests, though. > > -

RE: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Anthony Xu
Then you cannot create volume/template from snapshot. Anthony > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, August 03, 2012 6:35 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Marvin / Mockito / VHD-Tools - License header issues with > the t

Re: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 9:31 PM, Anthony Xu wrote: > It is not used by xenserver, XenServer uses itself vhd-util. > This vhd-util is used to deal with snapshot related operation. Ouch - ok, so core functionality. So what if it has to disappear from our repo and we can't have a dependency on it? (I

RE: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Anthony Xu
It is not used by xenserver, XenServer uses itself vhd-util. This vhd-util is used to deal with snapshot related operation. Anthony > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, August 03, 2012 6:26 PM > To: cloudstack-dev@incubator.apache.org > Subject:

RE: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-08-03 Thread Edison Su
> -Original Message- > From: Frank Zhang [mailto:frank.zh...@citrix.com] > Sent: Friday, August 03, 2012 5:35 PM > To: CloudStack DeveloperList > Subject: RE: [DISCUSS] Binaries (jars) in our source tree/source > releases. > > > > > Gradle seems to be another > > http://www.gradle.org/ >

Re: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 9:08 PM, Anthony Xu wrote: > Can we make it as a dependent package, this package will be installed when > CloudStack is installed? What if the answer is no? (that really is the default answer if we are talking about it being a dependency of the default build-path.) IF, ho

Unit test failures

2012-08-03 Thread Ewan Mellor
Hi everyone, We have fixed almost all of our unit tests, and we are down to 3 failures (two of which look like the same cause). The details are below. If someone has any ideas on these, then it would be greatly appreciated. We need a perfect green light on unit tests before we can release. T

RE: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Anthony Xu
Can we make it as a dependent package, this package will be installed when CloudStack is installed? Anthony. > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, August 03, 2012 2:40 PM > To: cloudstack-dev@incubator.apache.org > Subject: Re: Marvin / Mockito

RE: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-08-03 Thread Frank Zhang
> > Gradle seems to be another > http://www.gradle.org/ > > > Since it is allows scripting (as opposed to configuration xml), it could > potentially fulfill the waf role as well. > Anybody have any experience with Gradle? It seems Gradle received great reputation among famous java communities,

Re: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-08-03 Thread Chiradeep Vittal
Gradle seems to be another http://www.gradle.org/ Since it is allows scripting (as opposed to configuration xml), it could potentially fulfill the waf role as well. Anybody have any experience with Gradle? On 7/24/12 2:19 PM, "Alex Huang" wrote: >> Just out of curiosity, have tools like Ivy an

Re: ec2 API compatibility (WSDL vs Query)

2012-08-03 Thread Adrian Cole
Certainly, a public endpoint is easier on devs than a work-in-progress devstack. I'm not sure I will have time to work through that process in the short term. I am happy to help test an existing endpoint and maintain tests, though. -A On Aug 3, 2012 4:49 PM, "Ahmad Emneina" wrote: > This sound

Re: ec2 API compatibility (WSDL vs Query)

2012-08-03 Thread Ahmad Emneina
This sounds like thats the perfect job for devcloud. do an ant build-all from within devcloud and that should include building the awsapi/cloud bridge component. let us know what level of success you have. Adrian Cole wrote: I'm starting work on this here. http://code.google.com/p/jclouds/issues

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9838 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Libvirt

Re: proper SSL/ssh management

2012-08-03 Thread Hugo Trippaers
Hey John, Completely agree! I think it's pretty easy to make a central config flag for that. If it is there I will use that flag to check before loading the trust managers. Cheers, Hugo P.S. what about a hardening guide for CS? Sent from my iPhone On 3 aug. 2012, at 21:49, "John Kinsella"

RE: IPtables deb in source repo

2012-08-03 Thread Kevin Kluge
> > I believe it is already in Debian wheezy, so this is actually a backport. > Debian backports kernel for Squeeze broke something else (will have to dig it > up), so we couldn't use the backports kernel. > > What will break for folks is that: > - if they have a Ubuntu/Debian VM co-hosted on the

RE: CloudStack Events Plans

2012-08-03 Thread Kelcey Damage (BBITS)
Hmm, I think I need to upgrade my shirt to a monkey shirt :) Glad to hear OSCON went well, I was not able to make it. Kelcey Jamison-Damage Infrastructure Systems Architect Backbone Technology | Backbone Datavault | Backbone IT Services 55 East 7th Ave Vancouver - BC Canada V5T 1M4 kel...@bbits.

Re: Review Request: Introduce pluggable vif driver support on KVM

2012-08-03 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9837 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Libvirt

Re: CloudStack Events Plans

2012-08-03 Thread Duncan Johnston Watt
Hi. What are you guys planning to do at CloudOpen ( https://events.linuxfoundation.org/events/cloudopen/) in a few weeks? Let us know as we'd be happy to support this - chip in for beers or whatever. Best Duncan On 3 August 2012 22:46, Kevin Kluge wrote: > Mark, thanks for sharing your thought

Re: IPtables deb in source repo

2012-08-03 Thread Chiradeep Vittal
On 8/3/12 2:37 PM, "David Nalley" wrote: >On Fri, Aug 3, 2012 at 5:21 PM, Edison Su wrote: >> We can put the binary into somewhere, but in the source code. >> >>> -Original Message- >>> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] >>> Sent: Friday, August 03, 2012 2:13 P

RE: CloudStack Events Plans

2012-08-03 Thread Kevin Kluge
Mark, thanks for sharing your thoughts. I was at OSCON and thought CloudStack had a good booth. Everybody loved the monkey shirts! I'd also suggest getting some cards or some such thing with the cloudstack.org URL. If I recall correctly the monkey shirt does not have the URL. People wante

RE: License header audit complete, please help resolve the outstanding issues...

2012-08-03 Thread Kevin Kluge
Chip, I'm always happy to get mails that show progress being made. Thanks for all the effort on Apache CloudStack! -kevin > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, August 03, 2012 12:00 PM > To: cloudstack-dev@incubator.apache.org > Su

Re: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 4:31 PM, Anthony Xu wrote: > I'll remove vhd-tools directory. > There is a binary file ./scripts/vm/hypervisor/xenserver/vhd-util. > How should we deal with it? > Well there are several problems, 1) that binary is GPL licensed, and 2) it's a binary, which shouldn't live in

Re: IPtables deb in source repo

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 5:21 PM, Edison Su wrote: > We can put the binary into somewhere, but in the source code. > >> -Original Message- >> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] >> Sent: Friday, August 03, 2012 2:13 PM >> To: CloudStack DeveloperList >> Subject: Re: I

RE: ec2 API compatibility (WSDL vs Query)

2012-08-03 Thread Prachi Damle
Hi Chip, I have committed the change to remove WSDLs from the source tree. -Prachi -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Thursday, August 02, 2012 4:51 PM To: cloudstack-dev@incubator.apache.org Subject: Re: ec2 API compatibility (WSDL vs Query)

RE: IPtables deb in source repo

2012-08-03 Thread Edison Su
We can put the binary into somewhere, but in the source code. > -Original Message- > From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] > Sent: Friday, August 03, 2012 2:13 PM > To: CloudStack DeveloperList > Subject: Re: IPtables deb in source repo > > However this means that if

Re: IPtables deb in source repo

2012-08-03 Thread Chiradeep Vittal
However this means that if someone wants to build a system vm themselves (to add new packages for example), this fix will not be available. On 8/3/12 1:43 PM, "Edison Su" wrote: >From the git log: >commit aeda3f3a1c64efa1deb34f7fcb280e4155c4fe7d >Author: Sheng Yang >Date: Wed Dec 28 17:35:09

RE: xe-guest-utilities deb in source

2012-08-03 Thread Edison Su
Again, it's ok to remove it, the binary is already installed in system vm template. The deb package should be included in xenserver guest iso. > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, August 03, 2012 1:11 PM > To: cloudstack-dev@incubator.apache.org

RE: IPtables deb in source repo

2012-08-03 Thread Edison Su
>From the git log: commit aeda3f3a1c64efa1deb34f7fcb280e4155c4fe7d Author: Sheng Yang Date: Wed Dec 28 17:35:09 2011 -0800 bug 11056: Add customized iptables and kernel modules to the system template The new kernel module xt_CHECKSUM.ko is based on [1], and back ported to 2.6.32

RE: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Anthony Xu
I'll remove vhd-tools directory. There is a binary file ./scripts/vm/hypervisor/xenserver/vhd-util. How should we deal with it? Regards, Anthony > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, August 03, 2012 9:39 AM > To: cloudstack-dev@incu

Re: moving project_admin to SVN

2012-08-03 Thread Chip Childers
On Fri, Aug 3, 2012 at 4:14 PM, David Nalley wrote: > Hi folks, > > Unless someone screams about this, I think I am going to move > everything under project_admin out of git to the SVN repo. It's being > complained about with RAT, it adds little value to the downstream > consumers of our source re

moving project_admin to SVN

2012-08-03 Thread David Nalley
Hi folks, Unless someone screams about this, I think I am going to move everything under project_admin out of git to the SVN repo. It's being complained about with RAT, it adds little value to the downstream consumers of our source releases. Thoughts, comments, flames? --David

xe-guest-utilities deb in source

2012-08-03 Thread David Nalley
There's a xe-guest-utilities deb in source. patches/systemvm/debian/xe-guest-utilities_5.6.0-595_i386.deb Why is it here?; what happens with sysVMs when it gets removed (it supposedly is GPL/LGPL)? Is it a fork? --David

IPtables deb in source repo

2012-08-03 Thread David Nalley
Hi folks: There's a deb for what I assume is a forked/modified copy of iptables in source: patches/systemvm/debian/iptables_1.4.8-3local1checksum1_i386.deb Why is it here?; what if any changes were made to this?; when this gets deleted (iptables is GPL), does it create any problems for generatin

Re: License header audit complete, please help resolve the outstanding issues...

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 3:00 PM, Chip Childers wrote: > I'm sure everybody is getting sick of these emails (I'm certainly sick > of sending them), but I've wrapped up the first round of audit / > correction for the source code license headers. I tried to correct > everything that I was able to cor

proper SSL/ssh management

2012-08-03 Thread John Kinsella
Arve's made a comment in the "Official ASF process for re-writing code" thread about accepting SSL certs that I wanted to comment on, without hijacking that thread: CloudStack (and most (maybe all) Cloud management platforms I've seen) blindly accept any ssh host keys or SSL certificates they e

License header audit complete, please help resolve the outstanding issues...

2012-08-03 Thread Chip Childers
I'm sure everybody is getting sick of these emails (I'm certainly sick of sending them), but I've wrapped up the first round of audit / correction for the source code license headers. I tried to correct everything that I was able to correct easily, documented source and binary dependencies that we

RE: Patch: cloud-install-sys-tmplt

2012-08-03 Thread Vijayendra Bhamidipati
Hi, Can you please submit this patch in reviewboard(https://reviews.apache.org/dashboard/)? Please generate the patch using git format-patch -M -C -o ... You may need to run git diff --check before git format-patch to remove whitespace errors. Thanks! Regards, Vijay -Original Message---

Patch: cloud-install-sys-tmplt

2012-08-03 Thread mpatton
Not only does the original suffer from re-computing the same value over and over despite 'tmpfile' having been defined. This makes a maintenance headache. Worse, downloading files into /usr/lib* is VERBOTEN!! Options like /var/{tmp,lib} are at least proper but it makes vastly more sense to put the

CloudStack Events Plans

2012-08-03 Thread Hinkle Mark R.
Hello, Before CloudStack became Apache CloudStack we kept a pretty aggressive events schedule focused on evangelism and education of users on how to deploy CloudStack clouds primarily at open source venues (e.g. Linuxcon, Linuxfests), via free webinars and cloud computing events. Typically these

RE: Review Request: CS-15823 [VMware] failed snapshot entry should be removed automatically when multiple snopshots are taken on one volume simultaneously

2012-08-03 Thread Edison Su
I think if creating snapshot failed, no matter whatever reason, the snapshot should be marked as "Error". Just like the VM, if it's failed to create, them marked as "Error", then a background reclaim thread will expunge it. > -Original Message- > From: Mice Xia [mailto:mice_...@tcloudcom

Re: Official ASF process for re-writing code?

2012-08-03 Thread Hugo Trippaers
Hey Chip, Sure, happy to help out. I can probably get something done this weekend. Having this as a generic class could be a benefit for future integrations as well. I'll dive in to the code and keep track of this thread to see if I can help out. Cheers, Hugo Sent from my iPhone On 3 aug. 2

Re: Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Prasanna Santhanam
Yes - I think we can remove pymysql out of there and make it an external dep. I will clean up the sandbox as well in the morning. - Original Message - From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Friday, August 03, 2012 10:08 PM To: cloudstack-dev@incubator.apache.org S

Re: Official ASF process for re-writing code?

2012-08-03 Thread Chip Childers
Hugo, Just looked at your implementation. It does appear to do the same thing, which is fantastic. Would you happen to have any availability to attempt to replace the F5 code with something similar to your implementation? Perhaps it should be a utility class that can be shared between the two f

Re: Official ASF process for re-writing code?

2012-08-03 Thread Hugo Trippaers
Heya, Just pitching in without context, but I have some code in the Nicira stuff that does that, provided the code uses httpclient in the back. Cheers, Hugo Sent from my iPhone On 3 aug. 2012, at 13:02, "Arve Paalsrud" wrote: > I have not been able to get a response from Jacob Gilley throu

License headers for the UI folder look good.

2012-08-03 Thread Chip Childers
The license headers for the UI folder look good. There are a few exceptions reported, but we have accounted for them within the license tracking page here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Moving+dependencies+to+ASF+approved+licenses 23 Unknown Licenses ***

Marvin / Mockito / VHD-Tools - License header issues with the tools folder

2012-08-03 Thread Chip Childers
The tools folder has a couple of outstanding issues. RAT report here - https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/tools.txt Marvin: We have "reported" issues within the tools/marvin/marvin/pymysql and tools/marvin/marvin/sandbox directories. Are these used? Can we s

License headers clean for [python, scripts, server, setup, test] folders.

2012-08-03 Thread Chip Childers
These folders are good to go now: python, scripts, server, setup, test One key file is in the scripts folder (scripts/vm/systemvm/id_rsa.cloud), but that doesn't need a header. -chip https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/python.txt https://raw.github.com/chipchild

Re: Local storage support for data volumes

2012-08-03 Thread David Nalley
On Fri, Aug 3, 2012 at 1:34 AM, Koushik Das wrote: > Good suggestion David. The only downside about this is since the config is at > multiple level the user hopefully shouldn't get confused figuring out the > inheritance. > > -Koushik > Yes, and how behavior should be if it does use inheritance

License headers for the plugins folder <- Question about .patch files

2012-08-03 Thread Chip Childers
Three .patch files are in the plugin folder. Are they still needed? If so, does anyone know if we can add a license header to a patch file (Google either told me that I couldn't, or my Google-fu failed this morning)? RAT report for the plug folder here: https://raw.github.com/chipchilders/asf_clo

Re: Review Request: CS-15833: PreparForMigrationCommand should extend base Command object

2012-08-03 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6338/#review9824 --- Ship it! Ship It! - Nitin Mehta On Aug. 3, 2012, 10:46 a.m., Prasa

RE: What to do with Autoscale: was: Re: [6/11] AutoScale changes in Apache master

2012-08-03 Thread Vijay Venkatachalam
Done! Signed and sent. Thanks, -Vijay V. > -Original Message- > From: Ewan Mellor > Sent: Friday, August 03, 2012 11:48 AM > To: cloudstack-dev@incubator.apache.org; Pranav Saxena; David Nalley > Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg > Subject: RE: What to do with Autosc

RE: Official ASF process for re-writing code?

2012-08-03 Thread Arve Paalsrud
I have not been able to get a response from Jacob Gilley through a few channels, so we should move forward replacing the XTrustProvider class. It's not too big of a deal and shouldn't take long, but there are really not that many ways to do it. The task is pretty much to accept any SSL certifica

Re: Review Request: CS-15833: PreparForMigrationCommand should extend base Command object

2012-08-03 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6338/ --- (Updated Aug. 3, 2012, 10:46 a.m.) Review request for cloudstack, Nitin Mehta, e

Review Request: CS-15833: PreparForMigrationCommand should extend base Command object

2012-08-03 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6338/ --- Review request for cloudstack, Nitin Mehta, edison su, and Alex Huang. Descripti

Re: Review Request: Fix for CS-15621

2012-08-03 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6337/ --- (Updated Aug. 3, 2012, 10:09 a.m.) Review request for cloudstack, Prachi Damle a

Review Request: Fix for CS-15621

2012-08-03 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6337/ --- Review request for cloudstack, Prachi Damle and Nitin Mehta. Description ---

Regarding Runbook and L10N

2012-08-03 Thread Mice Xia
Hi, all As I was working on Chinese version of Runbook [1], I found some pieces of original document need to be updated. In chapter Configuration: - Pod Configuration This section consists of both pod setup and guest network setup, but they are two separate steps in zone wizard, can we split it

Re: Review Request: This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.

2012-08-03 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6328/#review9815 --- I looked at a few more that might need fixing. 1> All the .xml should

RE: Review Request: CS-15823 [VMware] failed snapshot entry should be removed automatically when multiple snopshots are taken on one volume simultaneously

2012-08-03 Thread Mice Xia
Remove the wrong reviewer from loop.. sorry for that, rely on auto-complete feature in review board but it turned out that was not Anthony Xu.. Yes, handling it in finally block seems more neat, but I need some background knowledge, i.e. in which situations failed snapshots should be expunged, a