----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9838 -----------------------------------------------------------
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java <https://reviews.apache.org/r/6285/#comment20855> This should not be a concern of the vif driver. Leave it in LibVirtComputingResource plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java <https://reviews.apache.org/r/6285/#comment20854> Instead of requiring the nicModel in the API definition, you can configure this subclass with a reference to LibVirtComputingResource. The plug API then looks like plug(NicTO nic, String guestOsType). The implementation of plug can ask LibVirtComputingResource for the nicModel plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java <https://reviews.apache.org/r/6285/#comment20857> Is it "nothing needed" or TODO? Please explain either way plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java <https://reviews.apache.org/r/6285/#comment20858> Not sure why the virtRouterResource gets involved here. Perhaps the method can be moved from there to here? plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java <https://reviews.apache.org/r/6285/#comment20856> This is where I would call configure() on the vifDriver plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java <https://reviews.apache.org/r/6285/#comment20853> Should not printStackTrace, use logger.error() instead - Chiradeep Vittal On Aug. 2, 2012, 11:18 p.m., Tomoe Sugihara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6285/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 11:18 p.m.) > > > Review request for cloudstack, edison su and Chiradeep Vittal. > > > Description > ------- > > Remove methods that are no longer needed in LibvirtComputingResource.java > > Signed-off-by: Tomoe Sugihara <to...@midokura.com> > > Add unplug() hook > > Signed-off-by: Tomoe Sugihara <to...@midokura.com> > > Add vif driver support > > - define abstract class named LibvirtVifDriver > - add LibvirtBridgeVifDriver to support current network implementation > - unplug() will be added > > Signed-off-by: Tomoe Sugihara <to...@midokura.com> > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtBridgeVifDriver.java > PRE-CREATION > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 73101a9896c4863bc75502ff8b0b6daceff52dc4 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVifDriver.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6285/diff/ > > > Testing > ------- > > Manually tested launching VM on all-in-one KVM box with Advanced networking. > > > Thanks, > > Tomoe Sugihara > >
