> -----Original Message----- > From: Brett Porter [mailto:br...@porterclan.net] On Behalf Of Brett Porter > > [Snip] > > > > > However, we do need to work out a process for accepting changesets with > multiple authors. It is very normal for two people to work on something and > for this to turn into a single changeset ready for review. This is > inevitable in > cases where people are buddy-coding, or where junior staff are having their > work checked internally, or where it's talking to something on the far side > (NetScaler 10 in this case) that is being developed in parallel. It is also > very > common when working with foreign teams (I have seen it a lot when working > with Japan) because most developers inside those teams can't speak English > and can't engage in the review process. We absolutely have to be prepared > for someone to show up with a patch who says "I am submitting this on > behalf of X, Y, and Z". > > > (Apologies if my cluelessness about the technology shows through here, but > hopefully you still get the point). > > What happens if there's a rockstar NetScaler developer lurking here - how do > they get involved in that? What if the people buddy-coding are working on > the same feature as someone that doesn't work with them - how will they > collaborate?
My point wasn't that people won't be collaborating. My point was that by the time things land in master, they may have multiple authors associated with them. The people working on this branch have been prototyping, making mistakes along the way, and keeping up with changes in the systems that they're talking to. And while all that has been going on, master has been moving forward at a great lick. By the time the feature lands in master, we're not going to see all those prototypes and mistakes, because it would be impossible to merge them all by now, and we certainly don't want to review changes that are wrong. We're going to see a small number of clean changesets that apply against HEAD. That's what we will be reviewing for submission into master. The consequence of that is that a single changeset will have multiple authors. This is what happened to Vijay B the other day -- he turned up with a sanitized, ready-for-merge changeset, and he got shouted at for submitting someone else's code. We have to figure out how to handle this. Telling him to go away isn't going to work. Ewan.
