[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367979: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. (authored by zer0, committed by ). Chan

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > jkorous wrote: > > > j

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 6 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote: >

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:329 + assert(!Path.empty() && "Path.empty()"); const int InotifyFD = inotify_init1(IN_CLOEXEC); @gribozavr As

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote: >

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > gribozavr wrote: > > plotfi wrote: > >

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi created this revision. plotfi added reviewers: jkorous, compnerd, gribozavr. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Also I went ahead and replaced all the instances of "auto DW = DirectoryWatcher::create" with "llvm::Expected> DW = DirectoryWatc

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi added a comment. @jkorous Can you lemme know if you're happy with https://reviews.llvm.org/D65829. @gribozavr lemme also know any other feedback in D65829 , as this diff here is already closed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) grib

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) grib

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) grib

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked an inline comment as done. plotfi added a comment. In D65829#1617850 , @lhames wrote: > I think the right line is: > > logAllUnhandledErrors(DW.takeError(), errs(), ""); > > > It's a bit wordy, but will log a sensible error and works wit

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi updated this revision to Diff 213742. plotfi added a comment. Updated to use logAllUnhandledErrors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 Files: clang/include/clang/DirectoryWatcher/Direct

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi added a comment. In D65829#1617864 , @compnerd wrote: > @lhames - I like the `logAllUnhandledErrors`! @lhames @compnerd @jkorous Only downside to using logAllUnhandledErrors over just letting the llvm::Expected's destructor handle the error prin

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368108: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create (authored by zer0, committed by ).

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. I tested this out. Seems to work fine, and print the Expected's Error. I am fine with it if @compnerd and @lhames and @jkorous are cool with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.org/D65853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. plotfi@grendel:/mnt/nvme0/llvm-project$ build/tools/clang/unittests/DirectoryWatcher/./DirectoryWatcherTests --gtest_filter=DirectoryWatcherTest.AddFilesNote: Google Test filter = DirectoryWatcherTest.AddFiles [==] Running 1 test from 1 test case. [

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

plotfi created this revision. plotfi added reviewers: aaron.ballman, compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am working to remove this concept of the "FinalPhase" in the clang driver, but it is used in a lot of different places to do argument handling fo

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

plotfi updated this revision to Diff 214222. plotfi added a comment. adding context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65969/new/ https://reviews.llvm.org/D65969 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp =

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368393: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes usage of FinalPhase from anywhere outside of the scope where it is used to do argument handling. It also adds argument based tri

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi updated this revision to Diff 214403. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 Files: clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cpp

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3220 - unsigned LastPLSize = 0; - for (auto &I : Inputs) { -types::ID InputType = I.first; -const Arg *InputArg = I.second; + { +Arg *FinalPhaseArg; aaron.ballman wrote: > Why

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:313-315 +for (auto Phase : PhaseList) + if (Phase <= phases::Preprocess) +P.push_back(Phase); aaron.ballman wrote: > How about: > > `ll

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi updated this revision to Diff 214408. plotfi added a comment. using llvm::copy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 Files: clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cp

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3220 - phases::ID FinalPhase; { Arg *FinalPhaseArg; @aaron.ballman How's this look to you now? I have another NFC patch coming up that will

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked 5 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:11 +#include "clang/Driver/Options.h" +#include "clang/Driver/DriverDiagnostic.h" #include "clang/Driver/Types.h" aaron.ballman wrote: > Can you sort th

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi updated this revision to Diff 214541. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 Files: clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cpp clang/lib/Driver/Types.cpp Index: clan

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change will go in on top of https://reviews.llvm.org/D65993. It simply moves the code that already exists into a new function. Repository:

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214545. plotfi added a comment. really sorry for how bad this diff looks. phab just doesnt present in a very ideal way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Types.h:107 +llvm::opt::DerivedArgList &DAL, ID Id, +llvm::SmallVectorImpl &Phases); compnerd w

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked an inline comment as done. plotfi added a comment. @aaron.ballman How does this look to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 ___ c

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

This revision was automatically updated to reflect the committed changes. Closed by commit rL368734: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; +

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214894. plotfi added a comment. Moved the initialization of YcArg and YuArg and initial handling of those args into handleArguments. ninja check-clang passes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://r

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214897. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp =

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; +

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi updated this revision to Diff 214896. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp =

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

plotfi added a comment. @aaron.ballman Good catch on the /Yc /Yu args. I like the way its looking a lot more now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 ___ cfe-comm

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 214924. plotfi edited the summary of this revision. plotfi added a comment. Herald added a subscriber: mgorny. Updated. Much better cleaner implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368881: [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 + OS << "IfsVersion: 1.0\n"; + OS << "Triple: " << T.str() << "\n"; + OS << "Symbols:\n"; This is missing O

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 +

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

plotfi updated this revision to Diff 216004. plotfi added a comment. Adding ObjectFileFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66446/new/ https://reviews.llvm.org/D66446 Files: clang/include/clang/Frontend/FrontendActions.h clang/i

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changing getFinalPhase to getPhasesToRun. Instead of only returning the final phase it returns the final phase as well as a collection of the phases to skip. This is useful for cases where you wa

[PATCH] D63978: Very early work on interface stub merger plumbing.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is really early. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63978 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains

[PATCH] D63978: Very early work on interface stub merger plumbing.

plotfi updated this revision to Diff 207224. plotfi added a comment. had some accidentally not-removed stray print output and/or expletives, apologies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Phases.h:30 +ID FinalPhase; +std::set SkipPhases; + }; I could change this to a SmallVector or SmallSet Repository: rG LLVM Github Monorepo

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi updated this revision to Diff 207227. plotfi added a comment. Add full context, change std::set to llvm::SmallSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63977/new/ https://reviews.llvm.org/D63977 Files: clang/include/clang/Driver/D

[PATCH] D63977: [NFC][clang] Adding ability to skip compiler phases in clang driver.

plotfi updated this revision to Diff 207228. plotfi added a comment. Removing obvious comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63977/new/ https://reviews.llvm.org/D63977 Files: clang/include/clang/Driver/Driver.h clang/include/cl

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1564747 , @ymandel wrote: > The tests for this code are failing in my build. Any suggestions welcome. > > My setup: > > cmake -G Ninja -DCMAKE_BUILD_TYPE=Release > -DCMAKE_C_COMPILER=/usr/bin/clang-7 -DCMAKE_CXX_COMPIL

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1564747 , @ymandel wrote: > The tests for this code are failing in my build. Any suggestions welcome. > > My setup: > > cmake -G Ninja -DCMAKE_BUILD_TYPE=Release > -DCMAKE_C_COMPILER=/usr/bin/clang-7 -DCMAKE_CXX_COMPIL

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565527 , @jfb wrote: > In D60974#1565517 , @jfb wrote: > > > In D60974#1565054 , @plotfi wrote: > > > > > So I think I know what may be goi

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565544 , @jfb wrote: > In D60974#1565541 , @plotfi wrote: > > > In D60974#1565527 , @jfb wrote: > > > > > In D60974#1565517

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @ymandel @jfb Thanks for reaching out on this. Apologies for missing this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-c

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565544 , @jfb wrote: > In D60974#1565541 , @plotfi wrote: > > > In D60974#1565527 , @jfb wrote: > > > > > In D60974#1565517

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565577 , @jfb wrote: > Looking at the code quickly, I'm not sure that this should be in clang > itself. It sounds like a better fit for a clang-based tool, and not clang. > Why does it need to be part of clang? In D

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565570 , @bruno wrote: > > I am currently working on the next part of clang interface stubs that will > > take the interface stubs per compilation unit and merge them into one text > > stub (which will be used by someth

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565577 , @jfb wrote: > Looking at the code quickly, I'm not sure that this should be in clang > itself. It sounds like a better fit for a clang-based tool, and not clang. > Why does it need to be part of clang? @jfb I

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565632 , @jfb wrote: > In D60974#1565621 , @plotfi wrote: > > > In D60974#1565577 , @jfb wrote: > > > > > Looking at the code quickly, I'm

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi added a reviewer: compnerd. Simplifying the phases generation process, first by copying the phases info into the Table. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 207659. plotfi marked 4 inline comments as done. plotfi added a comment. Update diff based on @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files:

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198963. plotfi marked 9 inline comments as done. plotfi added a comment. removed all the template functions to handle decls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D609

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198967. plotfi added a comment. cleaned up VisitNamedDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198977. plotfi added a comment. renaming things from "ifso" to "interface stubs" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Opti

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: llvm/lib/TextAPI/ELF/TBEHandler.cpp:137 IO.mapRequired("Arch", (ELFArchMapper &)Stub.Arch); +IO.mapOptional("Endian", Stub.Endian); IO.mapOptional("NeededLibs", Stub.NeededLibs);

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @jakehehrlich What else are you looking for here? Can the patch for merging tbe files come later? @compnerd @rupprecht thoughts? I think this is a reasonable compromise: a minimal subset of what the yaml2obj and llvm-elfabi (with the addition of the Endian field) tools c

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:58 ELFArch Arch; + Optional Endian; std::vector NeededLibs; jakehehrlich wrote: > Why do we need or want this? If it is needed can it

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added a comment. In D60974#1498240 , @jakehehrlich wrote: > This shouldn't emit the .tbe format at all, the .tbe format is meant to be in > near 1-1 correspondence with .so files, not with .o files. It has

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 199058. plotfi added a comment. Changing !tapi-tbe to !experimental-tapi-elf-v1, removing Endianness field from tapi-tbe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1498240 , @jakehehrlich wrote: > This shouldn't emit the .tbe format at all, the .tbe format is meant to be in > near 1-1 correspondence with .so files, not with .o files. It has things like > DT_NEEDED, and DT_SONAME r

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1498604 , @compnerd wrote: > This really needs more tests. Please add a positive/negative test for the > driver argument. Please try to organise the tests a bit to show what it is > that they are testing, emission of p

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 199112. plotfi added a comment. Adding lit test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/cla

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @compnerd Any other test cases you'd like before the first drop? @jakehehrlich @rupprecht Do things here look good to you guys? Both formats are marked experimental, I plan to work on a merge action next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. Herald added a subscriber: dexonsmith. In D62034#1506102 , @mstorsjo wrote: > Yes, MinGW headers are all lowercase. > > And the Windows SDK, where the file is spelled with a capital W, isn't > self-consistent (some headers include

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi updated this revision to Diff 200067. plotfi added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, cfe-commits, lebedev.ri, kadircet, arphaman, jkorous, christof, hiraditya, mgorny, ki.stfu, kubamracek. Herald added a reviewer: jfb. Herald added a reviewe

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. In D62034#1506879 , @mclow.lists wrote: > I have no objection to this; but I'm not really confident that this won't > break more than it solves. Actually, I think the existing VFS overlay would fix this without any changes. So I

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200393. plotfi added a comment. adding a nice inline test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200602. plotfi added a comment. fixing support for static functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200805. plotfi added a comment. adding static/extern tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/includ

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200828. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Types.def clang/include/clang/Fronten

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201104. plotfi added a comment. Improving visibility extraction for class template specializations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/includ

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201339. plotfi added a comment. More test improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/cla

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201471. plotfi added a comment. virtual function test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/clan

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added a comment. I think this change might be breaking builds: Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added a comment. I think this change might be breaking builds: http://lab.llvm.org:8011/builders/clang-aarch64-linux-build-cache/builds/16888 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 __

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } erichkeane wrote: > aheejin wrote: > > MaskRay wrote: > > > calculateAt

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221210. plotfi marked an inline comment as done. plotfi added a comment. fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driv

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 7 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:15 + +void tools::ifstool::Merger::ConstructJob(Compilation &C, const JobAction &JA, + const InputInfo &Outpu

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221252. plotfi added a comment. Adding back -c. Fixing driver for .ifs files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:328 +IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) { + return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221453. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221467. plotfi added a comment. tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.t

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221469. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

<    1   2   3   4   >