plotfi marked 2 inline comments as done. plotfi added inline comments.
================ Comment at: clang/include/clang/Driver/Driver.h:264 + const InputList &Inputs, ActionList &Actions, + llvm::opt::Arg *YcArg, llvm::opt::Arg *YuArg) const; + ---------------- plotfi wrote: > aaron.ballman wrote: > > I think the presence of the `YcArg` and `YuArg` parameters needs some > > explanation in the comments, as those seem rather out of place. > Those are the only corner case as far as things used and modified in the > scope. Was just trying to preserve the existing behavior. I think those two > args are used for clang-cl and the code that handles them just sets them to > nullptr. I can add a comment trying to explain what is happening here. There > were some tests that I remember were failing if those args weren't set to > nullptr after being used. I got rid of those arguments. Moved the code that starts setting those and using those variables into handleArguments. That makes sense to me since that code is handling the clang-cl /Yu and /Yc args. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
