plotfi marked an inline comment as done. plotfi added a comment. In D65829#1617850 <https://reviews.llvm.org/D65829#1617850>, @lhames wrote:
> I think the right line is: > > logAllUnhandledErrors(DW.takeError(), errs(), ""); > > > It's a bit wordy, but will log a sensible error and works with and without > ENABLE_ABI_BREAKING_CHECKS enabled. > > I'm not against improving the output for cantFail, nor totally against > abusing cantFail in unit tests, but Puyan's right that it would be abuse: in > production code cantFail should only be used at call sites where you know > from context that the call //definitely// can't fail (e.g. subsequent calls > to an API that can only fail on the first call). I am happy with this. Thanks @lhames ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
