plotfi marked 2 inline comments as done. plotfi added inline comments.
================ Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:58 ELFArch Arch; + Optional<std::string> Endian; std::vector<std::string> NeededLibs; ---------------- jakehehrlich wrote: > Why do we need or want this? If it is needed can it be added later when > needed? Also why is this a string? Just a suggestion, I saw that ELF needs endianness specified and I also saw that the llvm-elfabi tool (the latest patch set from phab anyways) has cmd clangs for specifying endianness and thought it could be nice to specify in the file. Also you are right, this probably shouldn't be a string. I can drop it from this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
