plotfi marked an inline comment as done.
plotfi added inline comments.

================
Comment at: clang/lib/Driver/Driver.cpp:3220
 
-  phases::ID FinalPhase;
   {
     Arg *FinalPhaseArg;
----------------
@aaron.ballman How's this look to you now? I have another NFC patch coming up 
that will move this entire block into its a separate function. I think finally 
this Drive::BuildActions code can have the code that handles and does things 
with various arguments separate from the actual job phase pipeline setup code. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65993/new/

https://reviews.llvm.org/D65993



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to