plotfi marked 4 inline comments as done. plotfi added inline comments.
================ Comment at: clang/include/clang/Driver/Types.h:107 + llvm::opt::DerivedArgList &DAL, ID Id, + llvm::SmallVectorImpl<phases::ID> &Phases); ---------------- compnerd wrote: > This really makes things confusing, perhaps renaming `getCompilationPhases` > to `getCompletePhaseList` or something might make it less confusing? > Although, I suppose that you do have follow up patches to improve this. I'm mainly going by the original name. But I can certainly do this in a followup patch. Actually I'd prefer to not do it here, and address this in a patch where I remove the other getFinalPhase method from the Driver class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
