[PATCH] D98131: [Driver] Pass --unwindlib=platform to tests that check unwinder

phosek created this revision. phosek added reviewers: mstorsjo, MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses an issue which was revealed by D98022 . Repository: rG LLVM

[PATCH] D98131: [Driver] Pass --unwindlib=platform to tests that check unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41476d89b826: [Driver] Pass --unwindlib=platform to tests that check unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D98158: [Driver] Pass --unwindlib=platform to tests that check unwinder

phosek created this revision. phosek added reviewers: MaskRay, mstorsjo. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are two additional cases that were missed in D98131 . Repository: rG

[PATCH] D98158: [Driver] Pass --unwindlib=platform to tests that check unwinder

phosek added a comment. I forgot to do a clean build and missed two more cases, after this everything seems to be green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98158/new/ https://reviews.llvm.org/D98158

[PATCH] D98158: [Driver] Pass --unwindlib=platform to tests that check unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7514f1a31275: [Driver] Pass --unwindlib=platform to tests that check unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D98142: [clang] Don't set CLANG_DEFAULT_UNWINDLIB to none if rtlib is set to compiler-rt

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98142/new/ https://reviews.llvm.org/D98142 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. @vsk do you have any thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek marked an inline comment as done. phosek added a comment. In D98061#2615239 , @vsk wrote: > @ributzka may have stronger thoughts about when -fprofile-instr-generate must > imply that a known set of symbols appear with external visibility. Up until

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek marked an inline comment as done. phosek added a comment. In D98061#2615334 , @vsk wrote: > In D98061#2615250 , @phosek wrote: > >> In D98061#2615239 , @vsk wrote: >>

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. In D98061#2615575 , @davidxl wrote: > Is the case when there is no counters very rare? And for those cases, how > much overhead the runtime hook can incur? I assume it is small compared with > actual instrumentation? I'll try t

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98375/new/ https://reviews.llvm.org/D98375 ___ c

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek updated this revision to Diff 329875. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Fuchsia

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG87fd09b25f88: [InstrProfiling] Generate runtime hook for ELF platforms (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https:

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary so we can run Polly tests in 2 s

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75cdeff43b2b: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting cortex-a53, set this linker flag rather than relying on

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass the --compress-debug-sections=zlib argument to the linker when the use of comp

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek added a comment. Herald added a subscriber: abrachet. @mcgrathr This might be ready to land now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44605/new/ https://reviews.llvm.org/D44605 ___ cfe-commits mailing l

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. @mcgrathr Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU == "cortex-a53") + CmdArgs.push_back("--fix-cortex-a53-843419"); mcgrathr

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 ___

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:812-828 +case CC_X86StdCall: +case CC_X86ThisCall: +case CC_X86FastCall: + return CCCR_Ignore; +case CC_C: +case CC_X86VectorCall: +case CC_IntelOclBicc: Accordin

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d89dbceeb57: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135471/new/ ht

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6f621b8cacc: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D135471?vs=469706&id=470014#toc Repository: rG LLVM G

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

phosek added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:265-267 +COMPILER_RT_VISIBILITY +void *__llvm_profile_keep[] = {(void *)&dummy_cnts, (void *)&dummy_data, + (void *)&dummy_name, (void *)&dummy_vnds}; ---

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

phosek added a comment. I wasn't included as a reviewer on D124857 and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in `InstrProfilingPlatformLinux.c`. AIX is neither Linux nor ELF-based and big chunks of that

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. On platforms like Linux, we nee

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

phosek added a comment. In D136664#3882989 , @smeenai wrote: > I might be missing it, but I don't see `crt` depending on `builtins` (or vice > versa). If there is actually no dep, could we build them together in a single > configure, instead of needing

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek added inline comments. Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVM) + endif() +else() +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +get_filename_component(LL

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. We started seeing test failures after this change on our bots. Would it be possible to revert the change and address these issues before relanding? In `Clang :: Driver/avr-ld.c`: Script: -- : 'RUN: at line 1'; /b/s/w/ir/x/w/staging/llvm_build/bin/clang -### --ta

[PATCH] D131919: Move googletest to the third-party directory

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Basic/Targets.cpp:579 +case llvm::Triple::UEFI: + //TODO(prabhukr): Template param check if required for other architectures + return new UEFITargetInfo(Triple, Opts); What does this comment refer

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. In D128133#3724984 , @benshi001 wrote: > @phosek , > > I have re-landed my patch, it seems the core reason is compiler-rt is default > in Fuchsia environment, other than libgcc. > > please inform me if it went wrong any longer. T

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4230319f7af: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7125-7127 + // Currently FatLTO objects only embed ThinLTO bitcode + if (Args.hasArg(options::OPT_ffat_lto_objects)) +CmdArgs.push_back("-flto=thin"); Rather than assuming ThinL

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

phosek added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content: 4243C0DE35140500620C30244D59BE669DFBB44F1BC8244401320500210C7B020B022100020016000781239141C80449061032399201840C250508191

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

phosek accepted this revision. phosek added a comment. LGTM Comment at: compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:103 LIBCXX_FLAGS="${FLAGS} -Wno-macro-redefined" PROJECTS= if [[ ! -d $LLVM_SRC/projects/libcxxabi ]] ; then ---

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 ___

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

phosek created this revision. phosek added a reviewer: mstorsjo. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We're seeing the following warnings with --rtlib=compiler-rt: lld-link: war

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

phosek updated this revision to Diff 455020. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132440/new/ https://reviews.llvm.org/D132440 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/com

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeca29d4a37b8: [Clang] Avoid using unwind library in the MSVC environment (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM In D132444#3743051 , @mstorsjo wrote: > In D132444#3743020 , @thakis wrote: > >> Makes sense to me. May

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

phosek added a comment. In D132440#3744960 , @mstorsjo wrote: >> This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d >> since >> the test fails in the per-target-runtime-dir

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

phosek added a comment. I agree with @tianshilei1992, I think we should avoid introducing new `CMAKE_` variables to avoid confusion. The same applies to module names, for example I don't think we should be introducing `GNUBinaryDirs` which can be easily confused for `GNUInstallDirs`. I would p

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3800479 , @andrewrk wrote: > if(LLVM_ENABLE_ZSTD) > list(APPEND imported_libs zstd::libzstd_shared) > endif() > > This hard codes shared linking which breaks the use case of static linking > LLVM. This was addr

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 ___

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

phosek added inline comments. Comment at: clang/CMakeLists.txt:912-926 +TABLEGEN +-DLLVM_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/llvm-tblgen +-DCLANG_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang-tblgen +LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_I

[PATCH] D132975: [CMake] Add clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 ___

[PATCH] D134693: [CMake] Add `CLANG_ENABLE_HLSL` CMake option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM (there's a typo in your summary in case you use it for the commit message: "proress" instead of "progress"). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

phosek added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:266 set(output_dir ${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION}/include) set(out_files) The property we maintain is that the build directory layout matches the installation di

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597 ___

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

phosek added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:1288-1293 + llvm::Type *ComponentType; + if (UseRelativeLayout(*this)) +ComponentType = Int32Ty; + else +ComponentType = Int8PtrTy; + CharUnits ComponentWidth = GetTargetTypeStoreSize(ComponentT

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

phosek added a comment. A possible alternative solution would be to build `clangSupport_sources` as an object library, and then link that library into `clangSupport` and `clang-tblgen` which could be done unconditionally; the advantage is that you don't need to compile `clangSupport_sources` tw

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3826150 , @mgorny wrote: > Is anyone working on a solution that would work for people using a zstd > install method that's actually supported upstream? I have created D134990 , it'd be

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: inglorion. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All our users have migrated to ld64.lld so we no long

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

phosek added a comment. This is just a nit, but I'd avoid extra formatting such as using `|` for separators and instead use just spaces and alignment akin to https://github.com/ClangBuiltLinux/frame-larger-than (or `llvm-readelf`) since that output tends to be easier to parse with tools like `c

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

phosek added a comment. In D134637#3835935 , @nhaehnle wrote: > Thank you all for the reviews. I've integrated the suggestions except for: > >> A possible alternative solution would be to build clangSupport_sources as an >> object library, and then link

[PATCH] D132975: [CMake] Add clang-bolt target

phosek added a comment. In D132975#3860896 , @Amir wrote: > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to implement >> and I'm glad someone else is alre

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#3862954 , @rjmccall wrote: > I suspect the Fuchsia project is not in fact volunteering to maintain a port > of every imaginable C++ ABI to Fuchsia. (Many of these "ABIs" are > specifically stuff like "the Itanium ABI as

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek created this revision. phosek added reviewers: smeenai, ldionne, mstorsjo, mgorny. Herald added subscribers: Enna1, abrachet. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers, libc++, libc++abi. Herald added subscribers: libcxx-c

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:41-45 +bool UEFI::IsUnwindTablesDefault(const ArgList &Args) const { + // TODO(prabhukr):: What about x86_32? + return getArch() == llvm::Triple::x86_64 || getArch() == llvm::Triple::arm || +

[PATCH] D140959: RFC: Multilib prototype

phosek added inline comments. Comment at: clang/include/clang/Driver/Multilib2.h:33-34 +private: + std::vector, std::vector>> Multilibs; + std::vector, std::vector>> RegexAttributes; +}; I think it'd really help readability and comprehension if this was model

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141073/new/ https://reviews.llvm.org/D141073 ___

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} --

[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code

phosek added inline comments. Comment at: clang/CMakeLists.txt:35 + include(StandaloneBuildHelpers) + get_llvm_utility_binary_path("llvm-tblgen" "LLVM_TABLEGEN_EXE") It's somewhat unusual to quote output variable names in our CMake files, I'd prefer to follo

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141342/new/ https://reviews.llvm.org/D141342 ___

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/ https://reviews.llvm.org/D141448 ___

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/ https://reviews.llvm.org/D137224 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek accepted this revision. phosek added a comment. Still LGTM, thanks for the explanation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

phosek added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:660 /// 'use-external-names': +/// 'root-relative': /// 'overlay-relative': Could we make this just a boolean akin to `overlay-relative` since there are only two o

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

phosek added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" We usually use lowercase na

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138062/new/ https://reviews.llvm.org/D138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

phosek added a comment. Is the plan to eventually rename `scudo_standalone` to `scudo` once the santiizer-based Scudo implementation is deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 __

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138258/new/ https://reviews.llvm.org/D138258 ___

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138472/new/ https://reviews.llvm.org/D138472 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564 ___

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

phosek added inline comments. Comment at: clang/CMakeLists.txt:959 ) add_custom_command(OUTPUT ${CLANG_OPTIMIZED} DEPENDS clang-bolt-profile We should consider placing this and all other intermediate outputs in `${CMAKE_CURRENT_BINARY_DIR}`. ===

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140565/new/ https://reviews.llvm.org/D140565 ___

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454 ___

[PATCH] D142917: [Fuchsia] Re-enable HWASan for globals in runtimes

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is now supported. Repository: rG LLVM Gith

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142917: [Fuchsia] Re-enable HWASan for globals in runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4308166403b4: [Fuchsia] Re-enable HWASan for globals in runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"

[PATCH] D143050: [Driver][Fuchsia] Remove relative vtable multilib

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We have made relative vtable the default fo

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:42-52 +foreach(variableName ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH_STRINGS}) + if(DEFINED ${variableName}) +set(BOOTSTRAP_${variableName} "${${variableName}}" CACHE STRING "") + endif() +endforeach() + +fo

[PATCH] D142878: Add testing for Fuchsia multilib

phosek added a comment. Thanks, some of these are no longer needed which could simplify this change so I sent out D143050 to clean up the Fuchsia driver first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878

[PATCH] D143092: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver

phosek created this revision. phosek added a reviewer: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This allows building static libraries with Clang driver. Repository: rG LLVM Gi

[PATCH] D143092: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5be69cd6af5: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143050: [Driver][Fuchsia] Remove relative vtable multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bdc9c9cf70a: [Driver][Fuchsia] Remove relative vtable multilib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143050/new/ https://revi

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

phosek added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:17 + + set(oneValueArgs PREFIX SUBDIR) + cmake_parse_arguments(RESOURCE_DIR "" "${oneValueArgs}" "" ${ARGN}) This variable is only used once on the following line, I'd just inline

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:20-46 +# Passthrough stage1 flags to stage1. +set(_FUCHSIA_BOOTSTRAP_PASSTHROUGH + LLVM_ENABLE_ZLIB + ZLIB_INCLUDE_DIR + ZLIB_LIBRARY + LLVM_ENABLE_ZSTD + zstd_DIR Could we move this

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143288/new/ https://reviews.llvm.org/D143288 ___

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but can you update the change title and description since the original one no longer matches the content of the patch. Comment at: clang/CMakeLists.txt:599-600 + if (W

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

phosek added a comment. Another alternative would be to move these classes to the Demangle library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 ___ cfe-comm

[PATCH] D143304: [Coverage] Map regions from system headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143304/new/ https://reviews.llvm.org/D143304 ___

[PATCH] D142878: Add testing for Fuchsia multilib

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:316-317 +void Fuchsia::configureMultilibFlags(Multilib::flags_list &Flags, + bool Exceptions, bool Asan, bool Hwasan, + bool I

<    6   7   8   9   10   11   12   13   14   15   >