phosek added inline comments.
================ Comment at: clang/cmake/caches/Fuchsia.cmake:20-46 +# Passthrough stage1 flags to stage1. +set(_FUCHSIA_BOOTSTRAP_PASSTHROUGH + LLVM_ENABLE_ZLIB + ZLIB_INCLUDE_DIR + ZLIB_LIBRARY + LLVM_ENABLE_ZSTD + zstd_DIR ---------------- Could we move this to a separate change since it's unrelated to the `llvm-rc` and `llvm-mt` change? ================ Comment at: clang/cmake/caches/Fuchsia.cmake:170-171 runtimes + llvm-rc + llvm-mt CACHE STRING "") ---------------- Could we do this in https://github.com/llvm/llvm-project/blob/98f0e4f611b40c902cb0df3ef080ae2c00e862d4/clang/CMakeLists.txt#L619? That would be more consistent with other tools such as `llvm-ar`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
