phosek added inline comments.

================
Comment at: clang/lib/Basic/Targets.cpp:579
+    case llvm::Triple::UEFI:
+      //TODO(prabhukr): Template param check if required for other 
architectures
+      return new UEFITargetInfo<X86_64TargetInfo>(Triple, Opts);
----------------
What does this comment refer to?


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:928
+                    MacroBuilder &Builder) const override {
+    //TODO(prabhukr): How to iniialize this info? Copy from Win?
+  }
----------------
I'd start with only necessary minimum and add more later if needed. Initially 
we probably only need a define to identify this target, likely `__UEFI__`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131594/new/

https://reviews.llvm.org/D131594

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D13... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
    • [PATCH... Petr Hosek via Phabricator via cfe-commits

Reply via email to