phosek added inline comments.
================ Comment at: clang/cmake/caches/Fuchsia.cmake:42-52 +foreach(variableName ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH_STRINGS}) + if(DEFINED ${variableName}) + set(BOOTSTRAP_${variableName} "${${variableName}}" CACHE STRING "") + endif() +endforeach() + +foreach(variableName ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH_BOOL}) ---------------- You should be able to use the following to avoid having to separate the variables by type: ``` foreach(variable ${PASSTHROUGH_VARIABLES}) get_property(is_value_set CACHE ${variable} PROPERTY VALUE SET) if(${is_value_set}) get_property(value CACHE ${variable} PROPERTY VALUE) get_property(type CACHE ${variable} PROPERTY TYPE) set(BOOTSTRAP_${variable} "${value}" CACHE ${type} "") endif() endforeach() ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits