phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land.
LGTM but can you update the change title and description since the original one no longer matches the content of the patch. ================ Comment at: clang/CMakeLists.txt:599-600 + if (WIN32) + # Build llvm-rc on Windows so it can be used to build + # bootstrap runtime. + add_dependencies(clang-bootstrap-deps llvm-rc) ---------------- Nit: spelling suggestion. ================ Comment at: clang/CMakeLists.txt:603-604 + if(LLVM_ENABLE_LIBXML2) + # Build llvm-mt if libxml2 is enabled and available. + # the existance of libxml2 is checked in llvm/cmake/config-ix.cmake. + add_dependencies(clang-bootstrap-deps llvm-mt) ---------------- Nit: I'd omit this since it doesn't provide any additional information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
