phosek added inline comments.
================
Comment at: clang/CMakeLists.txt:959
)
add_custom_command(OUTPUT ${CLANG_OPTIMIZED}
DEPENDS clang-bolt-profile
----------------
We should consider placing this and all other intermediate outputs in
`${CMAKE_CURRENT_BINARY_DIR}`.
================
Comment at: clang/CMakeLists.txt:966
-split-all-cold -split-eh -dyno-stats -icf=1 -use-gnu-stack
+ COMMAND ${CMAKE_COMMAND} -E rename ${CLANG_OPTIMIZED}
${CLANG_PATH}-${CLANG_VERSION_MAJOR}
COMMENT "Optimizing Clang with BOLT"
----------------
This makes assumptions about the name of the binary which is chosen by CMake
and can in theory change. Can you try to use generator expression instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139454/new/
https://reviews.llvm.org/D139454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
