[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill created this revision. Endill added reviewers: erichkeane, ychen, clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to D136133 . It wa

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478477. massberg added a comment. Fixed comments and removed unnecessary includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

steakhal added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that can of

[PATCH] D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions

tbaeder added a comment. Output for that test case is: ./array.cpp:1:16: error: constexpr function never produces a constant expression [-Winvalid-constexpr] constexpr void f() { ^ ./array.cpp:3:23: note: value 1292785156096 is outside the range of representable values of

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:423 + // Create labels and comparison ops for all case statements. + for (const SwitchCase *SC = S->getSwitchCaseList(); SC; + SC = SC->getNextSwitchCase()) { aaron.ballma

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478483. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-too

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___ cfe-commits ma

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

danielkiss added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7305 + if (Args.hasArg(options::OPT_mno_fmv)) { +CmdArgs.push_back("-target-feature"); maybe we need to add a check here for compiler-rt as rt-lib because today libgcc is

[PATCH] D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138900/new/ https://reviews.llvm.org/D138900

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg added a comment. Note: The build failures are in parts of the code that isn't effected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___

[clang] 3faf1f1 - [Clang] Implement static operator[]

Author: Roy Jacobson Date: 2022-11-29T12:39:52+02:00 New Revision: 3faf1f17a5c30a3ff1181898f2d2c7649066323d URL: https://github.com/llvm/llvm-project/commit/3faf1f17a5c30a3ff1181898f2d2c7649066323d DIFF: https://github.com/llvm/llvm-project/commit/3faf1f17a5c30a3ff1181898f2d2c7649066323d.diff

[PATCH] D138387: [Clang] Implement static operator[]

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faf1f17a5c3: [Clang] Implement static operator[] (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D138387?vs=477550&id=478493#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson updated this revision to Diff 478495. royjacobson edited the summary of this revision. royjacobson added a comment. rebase to retry CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138603/new/ https://reviews.llvm.org/D138603 Files:

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

david-arm updated this revision to Diff 478494. david-arm edited the summary of this revision. david-arm added a comment. - Changed patch to use autoupgrade mechanism. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138788/new/ https://reviews.llvm.org/D138788 Files: clang/include/clan

[clang] 849b650 - [clang] Skip defaulted functions in zero-as-null-pointer-constant.

Author: Jens Massberg Date: 2022-11-29T11:56:10+01:00 New Revision: 849b650cf3b60e60f5e3a6457fe52e9c63e76e4c URL: https://github.com/llvm/llvm-project/commit/849b650cf3b60e60f5e3a6457fe52e9c63e76e4c DIFF: https://github.com/llvm/llvm-project/commit/849b650cf3b60e60f5e3a6457fe52e9c63e76e4c.diff

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske added a comment. CppCoreGuidelines rule r13-perform-at-most-one-explicit-resource-allocation-in-a-single-expression-statement

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

royjacobson updated this revision to Diff 478502. royjacobson added a comment. Remove redundant comments, use Sema::AreConstraintExpressionsEqual instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138749/new/ https://reviews.llvm.org/D138749 F

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1324 +if ((NewRC != nullptr) != (OldRC != nullptr)) + // RC are most certainly different - these are overloads. + return true; --

[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. as discussed, this is a rather contained fix that are likely to help with other editors that might get confused with new-lines at EOF. so LGTM Repository: rG LLVM Github Monorepo CHANG

[PATCH] D138908: [clangd] Highlight "miscellaneous" types as `type` as a fallback.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +int Count = MainFile.code().substr(0, Offset).count('\n'); this is only used in

[clang-tools-extra] a53f895 - [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

Author: Sam McCall Date: 2022-11-29T13:15:20+01:00 New Revision: a53f89522f46dd10f87f163d8501738182729b8d URL: https://github.com/llvm/llvm-project/commit/a53f89522f46dd10f87f163d8501738182729b8d DIFF: https://github.com/llvm/llvm-project/commit/a53f89522f46dd10f87f163d8501738182729b8d.diff LO

[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

This revision was automatically updated to reflect the committed changes. Closed by commit rGa53f89522f46: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver added inline comments. Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/uar.cpp:1 +// We run the compiled binary + sizes of stack arguments depend on the arch. +// REQUIRES: native && target-x86_64 For LLVM IR tests, consider if utils/update_t

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9654-9655 +return true; + if (Ctx.isConstantEvaluated() || Ctx.isImmediateFunctionContext() || + Ctx.isUnevaluated()) +return false; cor3ntin wrote: > aaron.

[PATCH] D135171: FreeBSD: enable __float128 on x86

arichardson added a comment. @brooks do you want me to commit this for you or do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 478529. Sockke added a comment. Added test in existing `init-variables.cpp` file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.c

[PATCH] D137415: [clang][Interp] Implement switch statements

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:423 + // Create labels and comparison ops for all case statements. + for (const SwitchCase *SC = S->getSwitchCaseList(); SC; + SC = SC->getNextSwitchCase()) { tbaede

[clang] 3c75fea - [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

Author: Roy Jacobson Date: 2022-11-29T14:57:26+02:00 New Revision: 3c75feab3bbda563374f08e46a7c052c0c6f1c36 URL: https://github.com/llvm/llvm-project/commit/3c75feab3bbda563374f08e46a7c052c0c6f1c36 DIFF: https://github.com/llvm/llvm-project/commit/3c75feab3bbda563374f08e46a7c052c0c6f1c36.diff

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked 2 inline comments as done. Closed by commit rG3c75feab3bbd: [clang] Compare constraints before diagnosing mismatched ref qualifiers… (authored by roy

[clang] 13c3228 - [Clang] Implement LWG3823 for __is_aggregate

Author: Roy Jacobson Date: 2022-11-29T14:57:47+02:00 New Revision: 13c32288354b6175527f4fdece623157d3637da3 URL: https://github.com/llvm/llvm-project/commit/13c32288354b6175527f4fdece623157d3637da3 DIFF: https://github.com/llvm/llvm-project/commit/13c32288354b6175527f4fdece623157d3637da3.diff

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13c32288354b: [Clang] Implement LWG3823 for __is_aggregate (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] c64359e - [NFC] fix doc inconsistency in cxx_status

Author: Roy Jacobson Date: 2022-11-29T15:00:40+02:00 New Revision: c64359ea4c8ee9830dc828ed26d862a763f4535d URL: https://github.com/llvm/llvm-project/commit/c64359ea4c8ee9830dc828ed26d862a763f4535d DIFF: https://github.com/llvm/llvm-project/commit/c64359ea4c8ee9830dc828ed26d862a763f4535d.diff

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

miyuki added a comment. The CI failures look related to this change: https://buildkite.com/llvm-project/premerge-checks/builds/123301#0184aa94-1b82-44a9-9c25-4074e026d266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138679/new/ https://reviews.ll

[clang] 6b8900f - [clang][CodeGen] Add default attributes to __clang_call_terminate

Author: John Brawn Date: 2022-11-29T13:09:52Z New Revision: 6b8900f7f91de489302886c7e48033407d13f8c1 URL: https://github.com/llvm/llvm-project/commit/6b8900f7f91de489302886c7e48033407d13f8c1 DIFF: https://github.com/llvm/llvm-project/commit/6b8900f7f91de489302886c7e48033407d13f8c1.diff LOG: [c

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8900f7f91d: [clang][CodeGen] Add default attributes to __clang_call_terminate (authored by john.brawn). Changed prior to commit: https://reviews

[clang-tools-extra] 3c97f6c - [Support] Move getHostNumPhysicalCores to Threading.h

Author: Archibald Elliott Date: 2022-11-29T13:14:13Z New Revision: 3c97f6cab92fb3511d72996ac7ca8a8b459ebc88 URL: https://github.com/llvm/llvm-project/commit/3c97f6cab92fb3511d72996ac7ca8a8b459ebc88 DIFF: https://github.com/llvm/llvm-project/commit/3c97f6cab92fb3511d72996ac7ca8a8b459ebc88.diff

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rG3c97f6cab92f: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Changed prior to

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/45563 template concept True = true; template concept C1 =

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 abandoned this revision. usaxena95 added a comment. Second attempt along the lines of the last comment: https://reviews.llvm.org/D138914 PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712 __

[clang] b0e4897 - [OpenCL] Remove arm-integer-dot-product extension pragmas

Author: Sven van Haastregt Date: 2022-11-29T13:26:50Z New Revision: b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1 URL: https://github.com/llvm/llvm-project/commit/b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1 DIFF: https://github.com/llvm/llvm-project/commit/b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1.diff

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } we should report all references as explicit. =

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

tmatheson updated this revision to Diff 478540. tmatheson added a comment. Reinstate unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138753/new/ https://reviews.llvm.org/D138753 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Driv

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478545. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-too

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +int Count = MainFile.code().substr(0, Offset).count('\n'); hokein wrote: > this

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

aaron.ballman added inline comments. Comment at: clang/docs/SafeBuffers.rst:92 + +However, no automatic code modernizer for plain C is not provided, +and the hardened C++ standard library cannot benefit C code, which limits Comment at: clang/d

[PATCH] D138895: [clang] Update CWG2635 status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde36be740455: [clang] Update CWG2635 status (authored by Endill, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138895: [clang] Update CWG2635 status

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. woops, thanks! Committed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138895/new/ https://reviews.llvm.org/D138895 ___ cfe-comm

[clang] de36be7 - [clang] Update CWG2635 status

Author: Vlad Serebrennikov Date: 2022-11-29T05:54:34-08:00 New Revision: de36be74045533f6db0077c3f6cebaf258b63aaa URL: https://github.com/llvm/llvm-project/commit/de36be74045533f6db0077c3f6cebaf258b63aaa DIFF: https://github.com/llvm/llvm-project/commit/de36be74045533f6db0077c3f6cebaf258b63aaa.

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1435 * ``-fno-honor-nans`` - + * ``-fapprox-func`` * ``-fno-math-errno`` Leave a blank line before and after the bullet. Same below. Comment at: clang/docs/UsersMa

[clang-tools-extra] 454a34d - [include-cleaner] Fix -Woverloaded-virtual warning, NFC.

Author: Haojian Wu Date: 2022-11-29T15:09:56+01:00 New Revision: 454a34d2c04f68f3d7b907d78f3071710b93cf34 URL: https://github.com/llvm/llvm-project/commit/454a34d2c04f68f3d7b907d78f3071710b93cf34 DIFF: https://github.com/llvm/llvm-project/commit/454a34d2c04f68f3d7b907d78f3071710b93cf34.diff LO

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +i

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478556. VitaNuo added a comment. Address review comments: turn all references into explicit, remove the "isHeader" field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

erichkeane added a comment. I like the change, thank you! I don't see anything to be concerned about, but my python is awful, so I'd like at least a 2nd set of eyes to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https:/

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:87 - // headers might still be used by the dependents of the header. - if (!IsUsed && !IsHeader) -continue; ho

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), -

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though my Python skills are lacking, so additional eyeballs on that would be appreciated. Comment at: clang/www/make_cxx_dr_status:187-1

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478561. VitaNuo added a comment. Remove excessive method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +int Count = MainFile.code().substr(0, Offset).count('\

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill added a comment. Can I kindly ask you to commit this? I guess I can ask for commit access after this patch, and not bother you any further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https://reviews.llvm.org/D138901

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138918 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 478569. dvyukov marked 4 inline comments as done. dvyukov added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/c

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

cor3ntin added a comment. I don't see anything wrong with the python either. There are probably clever ways to deal with the successions of if statements but i don't think it would be worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

erichkeane added a comment. Thanks @cor3ntin , I'll commit this then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https://reviews.llvm.org/D138901 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov marked an inline comment as done. dvyukov added a comment. PTAL Comment at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp:254 + if (F.isVarArg()) +PerInstrFeatureMask &= ~kSanitizerBinaryMetadataUAR; + if (PerInstrFeatureMask & kSanitizerBinaryMe

[clang] 3d280b0 - [clang] Propely handle tests for open DRs in make_cxx_dr_status

Author: Vlad Serebrennikov Date: 2022-11-29T06:47:50-08:00 New Revision: 3d280b03753073960de9225f87780f5d6a4a2cb7 URL: https://github.com/llvm/llvm-project/commit/3d280b03753073960de9225f87780f5d6a4a2cb7 DIFF: https://github.com/llvm/llvm-project/commit/3d280b03753073960de9225f87780f5d6a4a2cb7.

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d280b037530: [clang] Propely handle tests for open DRs in make_cxx_dr_status (authored by Endill, committed by erichkeane). Repository: rG LLVM G

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rG7452e053e592: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support. (authored by VitaNuo).

[clang-tools-extra] 7452e05 - [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

Author: Viktoriia Bakalova Date: 2022-11-29T14:51:20Z New Revision: 7452e053e5921113ef59ccab04acc0999bf2ecc2 URL: https://github.com/llvm/llvm-project/commit/7452e053e5921113ef59ccab04acc0999bf2ecc2 DIFF: https://github.com/llvm/llvm-project/commit/7452e053e5921113ef59ccab04acc0999bf2ecc2.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/CodeGen/MachinePassRegistry.def:205 DUMMY_MACHINE_FUNCTION_PASS("print-machine-cycles", MachineCycleInfoPrinterPass, ()) +DUMMY_MACHINE_F

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver added inline comments. Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/uar.cpp:19 +void non_empty_function() { + // Completely empty functions don't get uar metadata. + volatile int x; Is this comment out of place? Repository: rG LLVM G

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. Are these features affecting the frontend functionality in any way? If not we should implement those in the headers and if headers are not flexible enough to condition out the addition of the new macros we should extend them (potentially by extending behaviour of `-cl

[clang] 0fae851 - [AIX][pg] Add Correct Search Paths for Profiled Libraries

Author: Michael Francis Date: 2022-11-29T10:16:27-05:00 New Revision: 0fae851824bc1b64a727aeb331b7a0787599bd1f URL: https://github.com/llvm/llvm-project/commit/0fae851824bc1b64a727aeb331b7a0787599bd1f DIFF: https://github.com/llvm/llvm-project/commit/0fae851824bc1b64a727aeb331b7a0787599bd1f.dif

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added a subscriber: jgorbe. alexfh added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = Sou

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added a comment. A gentle ping? Sorry if it bothers you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138028/new/ https://reviews.llvm.org/D138028 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 updated this revision to Diff 478592. qiongsiwu1 added a comment. Address review comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138854/new/ https://reviews.llvm.org/D138854 Files: clang/lib/Driver/ToolCh

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. @rjmccall Would you mind looking at this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D138920: [AArch64] Assembly support for VMSA

lenary added a comment. Two nits. One below, the other: Please include everyone who contributed to this patch in the patch description. Comment at: llvm/lib/Target/AArch64/AArch64.td:519 +def FeatureTHE : SubtargetFeature<"the", "HasTHE", +"true", "Enable Translation Harde

[clang] bfd69ad - [LinkerWrapper] Ignore OFK_None kinds for building registration code

Author: Joseph Huber Date: 2022-11-29T09:46:51-06:00 New Revision: bfd69ad59672e67d60e71d66df7ef878c18a7bb8 URL: https://github.com/llvm/llvm-project/commit/bfd69ad59672e67d60e71d66df7ef878c18a7bb8 DIFF: https://github.com/llvm/llvm-project/commit/bfd69ad59672e67d60e71d66df7ef878c18a7bb8.diff

[PATCH] D138920: [AArch64] Assembly support for VMSA

lenary added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:82 + AEK_THE = 1ULL << 50, // FEAT_THE + AEK_D128 =1ULL << 51, // FEAT_LSE128 + AEK_LSE128 = 1ULL << 52, // FEAT_D128 Comments don't correspond to na

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder updated this revision to Diff 478598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/ https://reviews.llvm.org/D138275 Files: clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h clang/lib/AST/Interp/InterpState.cpp clang/lib/AST/Interp/Interp

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno added a comment. @Anastasia I feel like I am following the guidance you quoted here. The defines I've deleted in `opencl-c-base.h` are blocking the possibility of `-cl-ext` working and would also get in the way of undefine preprocessor symbols working. If there is a problem with the addi

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

erichkeane added a comment. This is REALLY making me concerned again about ownership semantics in the interpreter. I don't have any real concerns with this patch-as-is, but I DO have concerns with the architecture that makes something like this necessary. CHANGES SINCE LAST ACTION https://r

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 478603. carlosgalvezp added a comment. Replace "the" anonymous namespace with "an" anonymous namespace Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 F

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please add a release note when landing since this fixes open issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138091/new/ https://reviews.llvm.org/D138091 __

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 478609. dvyukov marked 2 inline comments as done. dvyukov added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/c

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov marked an inline comment as done. dvyukov added inline comments. Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/uar.cpp:19 +void non_empty_function() { + // Completely empty functions don't get uar metadata. + volatile int x; melver wrote

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver accepted this revision. melver added inline comments. Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/uar.cpp:19 +void non_empty_function() { + // Completely empty functions don't get uar metadata. + volatile int x; dvyukov wrote: > melver

[clang] b12aea6 - [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

Author: Corentin Jabot Date: 2022-11-29T17:15:39+01:00 New Revision: b12aea6659e1170ecbc773a4a363dd0def93daa9 URL: https://github.com/llvm/llvm-project/commit/b12aea6659e1170ecbc773a4a363dd0def93daa9 DIFF: https://github.com/llvm/llvm-project/commit/b12aea6659e1170ecbc773a4a363dd0def93daa9.diff

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb12aea6659e1: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments (authored by cor3ntin). Herald added subscribers: kadircet,

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

cor3ntin added a comment. Thanks Erich! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138918/new/ https://reviews.llvm.org/D138918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet updated this revision to Diff 478611. kadircet marked 6 inline comments as done. kadircet added a comment. - Leaving out all the pieces around signals as discussed. - Update tests to use a LocateExample helper, have a test for macros. - Get rid of residues in other test files. Repositor

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D136554: Implement CWG2631

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/include/clang/Sema/Sema.h:9654-9655 +return true; + if (Ctx.isConstantEvaluated() || Ctx.isImmediateFunctionContext() || + Ctx.isUnevaluated()) +return fal

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. In D138597#3954269 , @probinson wrote: > Hmmm I might be inclined to emit 17 and 20 only under not-strict-DWARF for > v5, although it makes the logic more complicated. The codes have been > allocated but AFAICT the website doe

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:63 + + Gadget(Kind K) : K(K) {} + NoQ wrote: > aaron.ballman wrote: > > Should this be an explicit constructor? (Same question applies below to > > derived classes as well

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 478614. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-extra/include-cleaner/lib/Analysis.cpp clang-tools-

  1   2   3   >