melver accepted this revision.
melver added inline comments.
================
Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/uar.cpp:19
+void non_empty_function() {
+ // Completely empty functions don't get uar metadata.
+ volatile int x;
----------------
dvyukov wrote:
> melver wrote:
> > Is this comment out of place?
> If a function is completely empty, it won't be marked with UAR feature
> metadata.
> This is super-primitive approximation of the actual analysis we should do
> (the function has addr-taken/escaped locals/arguments).
> So I needed at least somebody for the function.
Ack
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136078/new/
https://reviews.llvm.org/D136078
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
