melver accepted this revision.
melver added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/include/llvm/CodeGen/MachinePassRegistry.def:205
DUMMY_MACHINE_FUNCTION_PASS("print-machine-cycles",
MachineCycleInfoPrinterPass, ())
+DUMMY_MACHINE_FUNCTION_PASS("machine-san-binary-md",
MachineSanitizerBinaryMetadata, ())
#undef DUMMY_MACHINE_FUNCTION_PASS
----------------
I called the LLVM IR pass just "sanmd-module".
So this could just be "machine-sanmd".
================
Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/common.h:54
+
+void __sanitizer_metadata_atomics_add() {}
+void __sanitizer_metadata_atomics_del() {}
----------------
Could make this have its real signature, i.e. add version,start,end args. Then
could also check in del that start,end matches, like above.
================
Comment at: llvm/test/Instrumentation/SanitizerBinaryMetadata/covered.cpp:1
+// REQUIRES: native && target-x86_64
+// RUN: clang++ %s -o %t && %t | FileCheck %s
----------------
dvyukov wrote:
> This is the new test.
Nice!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136078/new/
https://reviews.llvm.org/D136078
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
