VitaNuo added inline comments.
================ Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { + int Count = MainFile.code().substr(0, Offset).count('\n'); ---------------- hokein wrote: > this is only used in `IWYUKeep` test, I'd make it as a local lambda (with > MainFile captured) in the test: > > ``` > auto OffsetToLineNum = [&MainFile](size_t Offset) { ... }; > ``` Nice idea, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits