danielkiss added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7305
+ if (Args.hasArg(options::OPT_mno_fmv)) {
+ CmdArgs.push_back("-target-feature");
----------------
maybe we need to add a check here for compiler-rt as rt-lib because today
libgcc is not yet has the __aarch64_cpu_features.
================
Comment at: compiler-rt/lib/builtins/cpu_model.c:1311
+ // CPU features already initialized.
+ if (__aarch64_cpu_features.features)
+ return;
----------------
I'd add a init value for the declaration to be sure it is properly initialised.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127812/new/
https://reviews.llvm.org/D127812
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
