hokein added inline comments.
================ Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } ---------------- we should report all references as explicit. ================ Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:87 - // headers might still be used by the dependents of the header. - if (!IsUsed && !IsHeader) - continue; ---------------- The member field `IsHeader` is no longer used anywhere, we can remove it, which will simplify a few places, @kadircet any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits