[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +if (PrevToken->is(tok::r_brace) && Tok.is(tok::star) && +PrevToken->MatchingParen == nullptr) return TT_PointerOrReference;

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } qiucf wrote: > shchenz wrote: > > Can we use `path::parent_path(P)` directly in `addSystemInclude

[PATCH] D128048: Add a new clang option "-ftime-trace="

dongjunduo updated this revision to Diff 444898. dongjunduo added a comment. [Clang] restyle code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Driver/Options.td clang/inc

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

martong accepted this revision. martong added a comment. In D129678#3652859 , @ASDenysPetrov wrote: > Fixed a typo that caused `constraint_manager_negate.c` and `unary-sym-expr.c` > tests crashes. Good. Still LGTM. CHANGES SINCE LAST ACTION https:/

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/ https://reviews.llvm.org/D129498 ___ cfe-commits mailing list cfe-commits

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3648219 , @jdoerfert wrote: > > Can you share the output of the AST dump tests and the new check lines, so > what run produces and the file we give to Filechec to verify it. I looked at the AST test output and

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.cpp:35 +} + + aaron.ballman wrote: > There are some extra test cases I'd like to see coverage for because there > are some interesting edge cases to consider. > ``` > template >

[clang] 2f1555f - [C++20] [Modules] Handle reachability for enum class

Author: Chuanqi Xu Date: 2022-07-15T15:57:04+08:00 New Revision: 2f1555fb11d74376347ee94eb3af258e047f68ce URL: https://github.com/llvm/llvm-project/commit/2f1555fb11d74376347ee94eb3af258e047f68ce DIFF: https://github.com/llvm/llvm-project/commit/2f1555fb11d74376347ee94eb3af258e047f68ce.diff LO

[clang] 2a72137 - [IR] Don't use blockaddresses as callbr arguments

Author: Nikita Popov Date: 2022-07-15T10:18:17+02:00 New Revision: 2a721374aef326d4668f750d341c86d1aa1a0309 URL: https://github.com/llvm/llvm-project/commit/2a721374aef326d4668f750d341c86d1aa1a0309 DIFF: https://github.com/llvm/llvm-project/commit/2a721374aef326d4668f750d341c86d1aa1a0309.diff

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken &Tok, - const std::vector &Stack) { + const SmallVe

[PATCH] D129288: [IR] Don't use blockaddresses as callbr arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a721374aef3: [IR] Don't use blockaddresses as callbr arguments (authored by nikic). Herald added a reviewer: bollu. Herald added a project: clang. H

[clang] 3c849d0 - Modernize Optional::{getValueOr,hasValue}

Author: Fangrui Song Date: 2022-07-15T01:20:39-07:00 New Revision: 3c849d0aefa1101cf38586449c2105a97797c414 URL: https://github.com/llvm/llvm-project/commit/3c849d0aefa1101cf38586449c2105a97797c414 DIFF: https://github.com/llvm/llvm-project/commit/3c849d0aefa1101cf38586449c2105a97797c414.diff

[clang] 263dcf4 - [syntax] Introduce a TokenManager interface.

Author: Haojian Wu Date: 2022-07-15T10:30:37+02:00 New Revision: 263dcf452fa04d98456df04d2c3a753ba6d916ab URL: https://github.com/llvm/llvm-project/commit/263dcf452fa04d98456df04d2c3a753ba6d916ab DIFF: https://github.com/llvm/llvm-project/commit/263dcf452fa04d98456df04d2c3a753ba6d916ab.diff LO

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG263dcf452fa0: [syntax] Introduce a TokenManager interface. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 444911. manas added a comment. Add concrete tests for same and different types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/StaticAnalyzer/Core/Ra

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. The coverage showing unreachability of `VisitBinaryOperator` for concrete integer cases. F23801808: RangeConstraintManager.cpp.html Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1415-1416 + +

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added a comment. Thanks Denys for your continued work on this. These are very good questions that must be answered, we need exactly such thinking to implement this properly. I believe we can advance gradually. In D103096#3642681 , @ASDenysPetrov

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken &Tok, - const std::vector &Stack) { + const SmallV

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

eopXD added inline comments. Comment at: clang/lib/Driver/Driver.cpp:660 + +if (RVArch == llvm::Triple::riscv64 && +ArchName.startswith_insensitive("rv32")) Do we need to throw error (or warning) when these two (`RVArch` and `ArchName`) don't match?

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. The patch is LGTM, but please consider to keep an ignorelist limited. Comment at: clang/docs/SanitizerSpecialCaseList.rst:110-112 +``mainsrc`` can be useful enabling

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

DavidSpickett added a comment. FYI, after this change I get: /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: warning: 'clang::syntax::TokenBufferTokenManager' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] class To

[PATCH] D12669: [libcxxabi] Fix alignment of pointers returned by fallback_malloc

simon_tatham added a comment. I don't know if "silence implies no objection" is a reasonable assumption in this community, so for the sake of not treading on toes, I've put my revised version of the patch in a new location instead: D129842 . CHANGES SINCE LAS

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir updated this revision to Diff 444921. krasimir added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129771/new/ https://reviews.llvm.org/D129771 Files: clang/lib/Format/TokenAnnotator.cpp clang/unit

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir marked an inline comment as done. krasimir added a comment. In D129771#3653830 , @jackhong12 wrote: > I think we can also add new test cases in > `clang/unittests/Format/TokenAnnotatorTest.cpp`. > > Tokens = annotate("int i = int{42} * 34;");

[clang] 8dd2ef2 - [clang-format] distinguish multiplication after brace-init from pointer

Author: Krasimir Georgiev Date: 2022-07-15T11:45:12+02:00 New Revision: 8dd2ef2130852e406dab6097b1feb248bf16ce91 URL: https://github.com/llvm/llvm-project/commit/8dd2ef2130852e406dab6097b1feb248bf16ce91 DIFF: https://github.com/llvm/llvm-project/commit/8dd2ef2130852e406dab6097b1feb248bf16ce91.d

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dd2ef213085: [clang-format] distinguish multiplication after brace-init from pointer (authored by krasimir). Repository: rG LLVM Github Monorepo

[clang] 30c2406 - [syntax] Add virtual destructor in TokenManager.

Author: Haojian Wu Date: 2022-07-15T11:51:13+02:00 New Revision: 30c2406e270cc5dab8da813ce5c54e4bb8c40e49 URL: https://github.com/llvm/llvm-project/commit/30c2406e270cc5dab8da813ce5c54e4bb8c40e49 DIFF: https://github.com/llvm/llvm-project/commit/30c2406e270cc5dab8da813ce5c54e4bb8c40e49.diff LO

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

hokein added a comment. In D128411#3654452 , @DavidSpickett wrote: > FYI, after this change I get: > > > /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: > warning: 'clang::syntax::TokenBufferTokenM

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

sammccall added a comment. This matches what I did for clang-pseudo-gen. It looks reasonable to me, but I'd love to get a third opinion... (If none in a couple of days, happy to stamp it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129797/new/ h

[PATCH] D129648: Use pseudo parser for folding ranges

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:175 + + llvm::Optional Preprocessed; + Preprocessed = DirectiveStructure.stripDirectives(OrigStream); nit: no need to use llvm::Optional. Comment at: cla

[PATCH] D129648: Use pseudo parser for folding ranges

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:149 +target_include_directories(clangDaemon PUBLIC + ${CMAKE_CURRENT_SOURCE_DIR}/../pseudo/include +) It should rather be up to the clangPseudo target to specify its include di

Re: [PATCH] D129311: [clang-format] Update return code

Could someone please review this change? Thanks! — Sridhar > On Jul 11, 2022, at 12:55 PM, Sridhar Gopinath via Phabricator > wrote: > > sridhar_gopinath updated this revision to Diff 443726. > sridhar_gopinath added a comment. > > Replaced subprocess.check_call with subprocess.call since the

[PATCH] D129845: Allow custom attributes in access specifiers

eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, curdeius. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Allow custom attributes in acces

[PATCH] D128048: Add a new clang option "-ftime-trace="

dongjunduo updated this revision to Diff 444948. dongjunduo added a comment. [Clang] fix mkdir error in ftime-trace= test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Drive

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17863-17869 +/// Assuming the suggested solution to CWG2595 gets accepted: +/// [class.mem.special]p6: +/// An eligible special member function is a special member function for which: +/// - the function is n

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added a comment. Thanks for working on that! The patch looks very good overall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 ___ cfe-commits mailing

[clang] 5775c5d - Remove an unsued-variable warning, NFC.

Author: Haojian Wu Date: 2022-07-15T14:40:52+02:00 New Revision: 5775c5d05c91c82efef522043ddfb52c28e65b4d URL: https://github.com/llvm/llvm-project/commit/5775c5d05c91c82efef522043ddfb52c28e65b4d DIFF: https://github.com/llvm/llvm-project/commit/5775c5d05c91c82efef522043ddfb52c28e65b4d.diff LO

[PATCH] D129845: Allow custom attributes in access specifiers

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3304 + verifyFormat("class A {\n" + "public ATTR:\n" + " void f1() {}\n" How about multiple macros? E.g. `public ATTR1 ATTR2`? Repository: rG LLVM

[PATCH] D129845: [clang-format] Allow custom attributes in access specifiers

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3298 " void f6() {}\n" "signals:\n" " void g1();\n" In the same vein, could you add test for `slots:` and `Q_SLOTS:` please? Repo

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

hokein updated this revision to Diff 444956. hokein marked 2 inline comments as done. hokein added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129359/new/ https://reviews.llvm.org/D129359 Files: clang-tools-extra/pseudo/gen/

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:172 + // terminal `,` becomes `comma`; + // terminal `INT` becomes `int`; + std::string mangleSymbol(SymbolID) const; sammccall wrote: > I hope you me

[clang-tools-extra] 2315358 - [pseudo] Generate an enum type for identifying grammar rules.

Author: Haojian Wu Date: 2022-07-15T15:09:31+02:00 New Revision: 2315358906078cd35e2eb64bdcb711b2ec35 URL: https://github.com/llvm/llvm-project/commit/2315358906078cd35e2eb64bdcb711b2ec35 DIFF: https://github.com/llvm/llvm-project/commit/2315358906078cd35e2eb64bdcb711b2ec35.diff LO

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG231535890655: [pseudo] Generate an enum type for identifying grammar rules. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 444960. vaibhav.y added a comment. Undo test case renames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h clang/lib/Bas

[clang-tools-extra] 76910d4 - [pseudo] Share the underly payload when stripping comments for a token stream

Author: Haojian Wu Date: 2022-07-15T15:20:48+02:00 New Revision: 76910d4a56c8dba000f198bba13e71cf0492c8cb URL: https://github.com/llvm/llvm-project/commit/76910d4a56c8dba000f198bba13e71cf0492c8cb DIFF: https://github.com/llvm/llvm-project/commit/76910d4a56c8dba000f198bba13e71cf0492c8cb.diff LO

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

This revision was automatically updated to reflect the committed changes. Closed by commit rG76910d4a56c8: [pseudo] Share the underly payload when stripping comments for a token stream (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

erichkeane added a comment. In D129748#3653897 , @ChuanqiXu wrote: > In D129748#3651771 , @erichkeane > wrote: > >> I guess I don't have a good idea why this attribute would cause ODR issues? >> It would seem t

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

aaron.ballman added a comment. In D129748#3654909 , @erichkeane wrote: > I think there _IS_ perhaps an acceptability to ignoring this attribute when > it would cause a problem. However, I think doing it as you're doing it now > is wrong. IF we are go

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129280/new/ https://reviews.llvm.org/D129280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM assuming precommit CI comes back happy with it, thank you! I'll land it once I see things are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://review

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains reopened this revision. iains added a comment. This revision is now accepted and ready to land. reopening to post the patch I plan to re-land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 __

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains updated this revision to Diff 444965. iains added a comment. rebased, fixed interaction with clang modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

Wilco1 added a comment. The general requirement is that inline and outline atomics have identical behaviour, and that GCC and LLVM emit the same sequences. I agree __sync is badly documented, so it's hard to figure whether an extra DMB barrier could actually make a difference, but it's best to

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

BRevzin added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", It's possible that I just don't understand what these test

[PATCH] D129359: [pseudo] Generate an enum type for identifying grammar rules.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:48 +std::string Grammar::mangleSymbol(SymbolID SID) const { + static const char *const TokNames[] = { hokein wrote: > sammccall wrote: > > I'm not sure exposing these

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch changes the default linker for `clang`

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chrish_ericsson_atx added a comment. In D112374#3653967 , @JDevlieghere wrote: > I don't. I think reverting your change was well within the guidelines > outlined by LLVM's patch reversion policy: > https://llvm.org/docs/DeveloperPolicy.html#patch-rever

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444975. usaxena95 marked 15 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-t

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:185 +if (auto *Paired = Tok.pair()) { + if (Tok.Line < Paired->Line) { +Position Start = offsetToPosition( hokein wrote: > The `if` logic seems tricky, it

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein updated this revision to Diff 444976. hokein added a comment. rebase and address the main comment -- encoding the function-declarator into the grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129222/new/ https://reviews.llvm.org/D1292

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444 + if (Better1 && Better2) { +bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <= +LangOptions

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains reopened this revision. iains added a comment. This revision is now accepted and ready to land. reopening to post the patch I intend to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 444989. iains added a comment. rebased, fixed the interaction with clang module map modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files: clang/include/clan

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante accepted this revision. Mordante added a comment. LGTM, but please update the name of the flag in the title before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 ___

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm created this revision. Herald added subscribers: arphaman, mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. DylanFleming-arm requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This patch

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">, DefaultFalse, - PosFlag, +defm experimental_library : BoolFOption<"experimental-library", + LangOpts<"ExperimentalLibrary">,

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 445002. usaxena95 added a comment. Removed unused headers and fix spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMake

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne added a subscriber: mstorsjo. ldionne added a comment. The `experimental-library-flag` test is currently failing on Windows because on Windows, `-stdlib=libc++` seems to be ignored and we don't add `-lc++` or `-lc++experimental`. Does someone understand how things are supposed to work w

[clang] f5d9de8 - [Clang] Add a new clang option "-ftime-trace="

Author: dongjunduo Date: 2022-07-15T08:55:17-07:00 New Revision: f5d9de8cc33014923fbd1c5682758557887e85ba URL: https://github.com/llvm/llvm-project/commit/f5d9de8cc33014923fbd1c5682758557887e85ba DIFF: https://github.com/llvm/llvm-project/commit/f5d9de8cc33014923fbd1c5682758557887e85ba.diff LO

[PATCH] D128048: Add a new clang option "-ftime-trace="

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5d9de8cc330: [Clang] Add a new clang option "-ftime-trace=" (authored by dongjunduo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ http

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

kstoimenov accepted this revision. kstoimenov added a comment. I think the name 'mainsrc' is slightly misleading because of the association with the 'main' function. Maybe something like primarysrc would be better to avoid this confusion? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 created this revision. jyu2 added reviewers: ddpagan, ABataev, mikerice. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-com

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a proje

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 _

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129303/new/ https://reviews.llvm.org/D129303 _

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129304/new/ https://reviews.llvm.org/D129304 _

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j abandoned this revision. lamb-j added a comment. Abandoned in favor of combined patch: https://reviews.llvm.org/D129873 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129305/new/ https://reviews.llvm.org/D129305 _

[PATCH] D129835: [clang] adds a discardable attribute

aaron.ballman added a comment. > When we have a function that can have its value discarded, we can use > [[clang::discardable]] to indicate that the `[[nodiscard]]` attribute should > be ignored. Alternatively, you can scope the pragma and declarations appropriately and then we don't need to a

[clang] 82f76c0 - [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

Author: Denys Petrov Date: 2022-07-15T19:24:57+03:00 New Revision: 82f76c04774fbeb2313b84932afac478f010c8d0 URL: https://github.com/llvm/llvm-project/commit/82f76c04774fbeb2313b84932afac478f010c8d0 DIFF: https://github.com/llvm/llvm-project/commit/82f76c04774fbeb2313b84932afac478f010c8d0.diff

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

This revision was automatically updated to reflect the committed changes. Closed by commit rG82f76c04774f: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay added a comment. In D129832#3654436 , @vitalybuka wrote: > The patch is LGTM, but please consider to keep an ignorelist limited. Thanks! In D129832#3655393 , @kstoimenov wrote: > I think the name 'm

[PATCH] D129835: [clang] adds a discardable attribute

cjdb added a subscriber: ldionne. cjdb added a comment. In D129835#3655487 , @aaron.ballman wrote: >> When we have a function that can have its value discarded, we can use >> [[clang::discardable]] to indicate that the `[[nodiscard]]` attribute should

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. I'm not following what the root problem is. You stated: > When we write the attribute preferred_name(foo) in ASTWriter, the compiler > would try to write the type for the argument foo. Then when the compiler > write the type for foo, the compiler find the type for f

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. @manas I'm sorry but it seems like I brought you a new work :-) I've just loaded these two patches (D129678 and D129498 ) and now you have to rebase your changes. But there is a good news as wel

[clang] bc08c3c - [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

Author: Denys Petrov Date: 2022-07-15T20:07:04+03:00 New Revision: bc08c3cb7f8e797fee14e96eedd3dc358608ada3 URL: https://github.com/llvm/llvm-project/commit/bc08c3cb7f8e797fee14e96eedd3dc358608ada3 DIFF: https://github.com/llvm/llvm-project/commit/bc08c3cb7f8e797fee14e96eedd3dc358608ada3.diff

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 445044. royjacobson edited the summary of this revision. royjacobson added a comment. Address Corentin's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked 4 inline comments as done and an inline comment as not done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17960-17961 +} +if (AnotherMethodIsMoreConstrained) + break; + } cor3ntin wrot

[PATCH] D129835: [clang] adds a discardable attribute

aaron.ballman added a comment. In D129835#3655548 , @cjdb wrote: > In D129835#3655487 , @aaron.ballman > wrote: > >>> When we have a function that can have its value discarded, we can use >>> [[clang::discardabl

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

BRevzin added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", royjacobson wrote: > BRevzin wrote: > > It's possible that

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. I guess Kirills' complain is about **main** part, not **src**. But I have no idea what name could be better. I guess thechnically it's preprocessed src? :) To me as is name is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. "unit:" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129832/new/ https://reviews.llvm.org/D129832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D129832: [sanitizer] Add "mainfile" prefix to sanitizer special case list

MaskRay updated this revision to Diff 445051. MaskRay retitled this revision from "[sanitizer] Add "mainsrc" prefix to sanitizer special case list" to "[sanitizer] Add "mainfile" prefix to sanitizer special case list". MaskRay edited the summary of this revision. MaskRay added a comment. mainsrc

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman created this revision. aaron.ballman added reviewers: efriedma, jyknight, erichkeane, clang-language-wg. Herald added subscribers: steakhal, Enna1, kosarev, arphaman, jvesely. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang,

[clang] 0d5a62f - [sanitizer] Add "mainfile" prefix to sanitizer special case list

Author: Fangrui Song Date: 2022-07-15T10:39:26-07:00 New Revision: 0d5a62faca5924c5a197faa946b5b78b3d80a0b2 URL: https://github.com/llvm/llvm-project/commit/0d5a62faca5924c5a197faa946b5b78b3d80a0b2 DIFF: https://github.com/llvm/llvm-project/commit/0d5a62faca5924c5a197faa946b5b78b3d80a0b2.diff

[PATCH] D129832: [sanitizer] Add "mainfile" prefix to sanitizer special case list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d5a62faca59: [sanitizer] Add "mainfile" prefix to sanitizer special case list (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39 + +template struct DefaultConstructorCheck<2>; +// CHECK: "kind": "ClassTemplateSpecializationDecl", BRevzin

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese, akyrtzi. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "strict context hash" is insufficient to identify

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

erichkeane added a comment. This seems like a good idea despite the breaking change. I dont see anything in the code to be concerned about, but I'm hoping others will comment as to whether this is completely acceptable. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8482 Ex

  1   2   >