MaskRay added a comment.


In D129832#3654436 <https://reviews.llvm.org/D129832#3654436>, @vitalybuka 
wrote:

> The patch is LGTM, but please consider to keep an ignorelist limited.

Thanks!

In D129832#3655393 <https://reviews.llvm.org/D129832#3655393>, @kstoimenov 
wrote:

> I think the name 'mainsrc' is slightly misleading because of the association 
> with the 'main' function. Maybe something like primarysrc would be better to 
> avoid this confusion?

How   about `mainfile`? Clang resources to the file as the `main file`. I 
picked `src` suffix just to be similar to `src`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129832/new/

https://reviews.llvm.org/D129832

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to