vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land.
The patch is LGTM, but please consider to keep an ignorelist limited. ================ Comment at: clang/docs/SanitizerSpecialCaseList.rst:110-112 +``mainsrc`` can be useful enabling a ubsan check for a large code base when +finding the direct stack frame triggering the failure for every failure is +difficult. ---------------- MaskRay wrote: > vitalybuka wrote: > > if this is transitionalt solution, would it be better just to use > > -fno-sanitize= on *.cpp file? > This provides a more convenient way than using `-fno-sanitize=` for a > different set of files. > > E.g. if a group wants to ignore a check for all ``[a-m]*` files, then can use > `mainsrc:[a-m]*` instead of patching the build system. Convenience of -fno-sanitize= approach that you make it visible to maintainer of component. Then it's their responsibility. Ignore list is toolchain team debt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129832/new/ https://reviews.llvm.org/D129832 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
