aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
================
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444
+ if (Better1 && Better2) {
+ bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <=
+ LangOptions::ClangABI::Ver14;
----------------
ychen wrote:
> aaron.ballman wrote:
> > Can you add CodeGen test coverage for both ABI modes (new RUN line with
> > `-fclang-abi-compat=14`)
> Some test cases could reach the CodeGen phase *with*
> `-fclang-abi-compat=14`(i.e without this patch), some test cases could reach
> the CodeGen phase *without* `-fclang-abi-compat=14`(i.e with this patch).
> Please let me know if the added CodeGen tests are what you expected.
Yes, that test is what I was looking for, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128745/new/
https://reviews.llvm.org/D128745
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
