shchenz added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 + path::remove_filename(P); + addSystemInclude(DriverArgs, CC1Args, P); } ---------------- qiucf wrote: > shchenz wrote: > > Can we use `path::parent_path(P)` directly in `addSystemInclude()`? > > `remove_filename()` sounds like `ppc_wrappers` is a file. > It just wraps `parent_path`, and `parent_path` only accepts (and returns) > `StringRef`. ``` addSystemInclude(DriverArgs, CC1Args, path::parent_path(P.str())); ``` Above change works for me? I think it should be functionality right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
