[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 created this revision. Herald added a subscriber: kristof.beyls. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements minimum support in clang for default HBC/MOPS features on v8.8-a/v9.3-a or later architectures.

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119144/new/ https://reviews.llvm.org/D119144 ___

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu updated this revision to Diff 409872. ChuanqiXu retitled this revision from "[C++20] [Modules] Remain internal-linkage variables in module interface unit" to "[C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit ". ChuanqiXu edited the summa

[clang] 5333447 - [NFC] Fix a buildbot failure after b529744

Author: hyeongyukim Date: 2022-02-18T17:38:50+09:00 New Revision: 5333447a00ff568e5029483e1b46041ad1c9788f URL: https://github.com/llvm/llvm-project/commit/5333447a00ff568e5029483e1b46041ad1c9788f DIFF: https://github.com/llvm/llvm-project/commit/5333447a00ff568e5029483e1b46041ad1c9788f.diff L

[clang] c85a264 - [asan] Add support for disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2022-02-18T09:51:54+01:00 New Revision: c85a26454d4b3dab383555c3864568b7aff9c225 URL: https://github.com/llvm/llvm-project/commit/c85a26454d4b3dab383555c3864568b7aff9c225 DIFF: https://github.com/llvm/llvm-project/commit/c85a26454d4b3dab383555c3864568b7aff9c225

[PATCH] D120055: [asan] Add support for disable_sanitizer_instrumentation attribute

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc85a26454d4b: [asan] Add support for disable_sanitizer_instrumenta

[clang] 35baa26 - [NFC][Clang/test] add target triple to CodeGen/analyze_noundef.cpp

Author: hyeongyukim Date: 2022-02-18T17:54:22+09:00 New Revision: 35baa26747b0033afac15d7989bc2100b251412c URL: https://github.com/llvm/llvm-project/commit/35baa26747b0033afac15d7989bc2100b251412c DIFF: https://github.com/llvm/llvm-project/commit/35baa26747b0033afac15d7989bc2100b251412c.diff L

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG: @inline_var_

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. It looks like this patch changed the value of `__FLT_EVAL_METHOD__` when building on macOS for some configurations. This is causing build failures when using macOS 10.15's `math.h` and that is breaking most builds on GreenDragon, e.g. : https://green.lab.llvm.org/green/j

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); ChuanqiXu wrote: > iains wrote: > > urnathan wrote: > > > iains wrote: > > > > ChuanqiXu wrote:

[PATCH] D112916: Confusable identifiers detection

cor3ntin added a comment. In D112916#3314184 , @cor3ntin wrote: > @aaron.ballman Thanks for the ping. > > One one hand, I agree with you, on the other hand, this tries to stick to > TR39, and I think we should stick with that. It might be worth checking

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro marked 2 inline comments as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we use sysroot to make these tests Mas

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 409881. ro marked 2 inline comments as done. ro added a comment. Test fixes as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files: clang/lib/Driv

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. It appears that this is causing an assertion segfault in a `rustc` test over at our experimental rust + llvm@head bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8430#167e6de5-2dd5-41c3-87d7-b6e3f3908371/262-706 The test is https://github.co

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

nlopes added a comment. Well, this patch is just a band-aid and a disaster waiting to happen. If kmalloc is tagged with an __attribute__ stating the allocation size, then you can't dereference beyond that limit or risk the alias analysis do something you don't want. You are triggering UB like th

[clang] 5086cff - Revert "unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82"

Author: Florian Hahn Date: 2022-02-18T11:04:05Z New Revision: 5086cff04eec4327acc22a90466854ad4d89d570 URL: https://github.com/llvm/llvm-project/commit/5086cff04eec4327acc22a90466854ad4d89d570 DIFF: https://github.com/llvm/llvm-project/commit/5086cff04eec4327acc22a90466854ad4d89d570.diff LOG:

[clang] 09193f2 - Revert "Add support for floating-point option `ffp-eval-method` and for"

Author: Florian Hahn Date: 2022-02-18T11:04:00Z New Revision: 09193f20a13e8c3f4196dcc0883d74396f44c3cf URL: https://github.com/llvm/llvm-project/commit/09193f20a13e8c3f4196dcc0883d74396f44c3cf DIFF: https://github.com/llvm/llvm-project/commit/09193f20a13e8c3f4196dcc0883d74396f44c3cf.diff LOG:

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! This is worth mentioning in the clang release notes. (Along with any matchers that match these new nodes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] 535e7b0 - [clangd] lookupSiblingsWithinContext - remove unnecessary nullptr check

Author: Simon Pilgrim Date: 2022-02-18T11:12:53Z New Revision: 535e7b09c189dd3a7ef65bd36a02962f0c98bd5e URL: https://github.com/llvm/llvm-project/commit/535e7b09c189dd3a7ef65bd36a02962f0c98bd5e DIFF: https://github.com/llvm/llvm-project/commit/535e7b09c189dd3a7ef65bd36a02962f0c98bd5e.diff LOG:

[clang] 977b1f5 - [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

Author: Kadir Cetinkaya Date: 2022-02-18T12:16:38+01:00 New Revision: 977b1f574fa18219fde5f709b906c79202ef1916 URL: https://github.com/llvm/llvm-project/commit/977b1f574fa18219fde5f709b906c79202ef1916 DIFF: https://github.com/llvm/llvm-project/commit/977b1f574fa18219fde5f709b906c79202ef1916.dif

[PATCH] D120081: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG977b1f574fa1: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1200

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 409892. hokein marked 14 inline comments as done. hokein added a comment. - address comments - more api polishments - LRGraph unittest => lit tests - hide LRTable::Builder, move to LRTableBuild.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 409893. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118196/new/ https://reviews.llvm.org/D118196 Files: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h clang/include/cla

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:177 }; +void initTerminals(std::vector &Terminals); sammccall wrote: > why is this exposed/required rather than being initialized by the > GrammarTable constructor?

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:368 Loc makeNullWithType(QualType type) { -return loc::ConcreteInt(BasicVals.getZeroWithTypeSize(type)); - } - - Loc makeNull() { -return loc::ConcreteInt

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3331396 , @ChuanqiXu wrote: > Thanks for explanation. Now it looks good to me. Let's accept it formally > after the series of partition landed and so that we could add test about > partitions. thanks, We're going t

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); iains wrote: > ChuanqiXu wrote: > > iains wrote: > > > urnathan wrote: > > > > iains wrote: >

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers updated this revision to Diff 409896. vabridgers added a comment. refactor based on @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 Files: clang/include/clang/StaticAnalyze

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2540-2541 ///} /// \endcode - /// \version 13 + /// \version 15 bool IndentRequiresClause; HazardyKnusperkeks wrote: > I like that suggestion.. Repository: r

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

MyDeveloperDay added a comment. I like `/// In clang-format 13 and 14 it was named ``IndentRequires``.` The code in theory should still support it so it should be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https://review

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. See https://github.com/clangd

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

melver added a comment. What about this test then: https://github.com/llvm/llvm-project/blob/b0a0df980927ca54a7840a1b0c9766e98c05039b/clang/test/CodeGen/sanitize-coverage.c#L74 Can you show an independent C reproducer where no_sanitize does not work for you? Is there an LKML discussion? I als

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall updated this revision to Diff 409902. sammccall marked 4 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 Files: clan

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. In D119537#3323096 , @Trass3r wrote: > Is it intentional that the resolved type is not shown in the variable hover > (I guess, looking at the code): > > param payload > Type: const auto & > > // In subscribe::(anonymou

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

melver added a comment. Right, I was able to repro this. The problem is the trap, which generally sucks that no_sanitize still leaves in the trap. We also have -fno-sanitize-undefined-trap-on-error, which seems to have no effect either (should it?). So I think there are 2 problems: 1. Clang s

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 ___

[PATCH] D120106: [OpenMP] Add flag for disabling thread state in runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG0870a4f59aef: [OpenMP] Add flag for disabling thread state in runtime (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https

[clang] 0870a4f - [OpenMP] Add flag for disabling thread state in runtime

Author: Joseph Huber Date: 2022-02-18T08:35:05-05:00 New Revision: 0870a4f59aef21bf7707b00ebd4dcad7ce7ef807 URL: https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807 DIFF: https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807.diff

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + yaxunl wrote: > tra wrote: > > Is this file necessary? `clang -###` should not need the file t

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Thank you for reverting my follow-up as well! zahiraam, for the reland please include that follow-up fix in your commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3331914 , @thakis wrote: > Thank you for reverting my follow-up as well! > > zahiraam, for the reland please include that follow-up fix in your commit :) Yes. Will do that. Thanks. Repository: rG LLVM Github Monor

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:372 - Loc makeNull() { -return loc::ConcreteInt(BasicVals.getZeroWithPtrWidth()); } steakhal wr

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3331641 , @krasimir wrote: > It appears that this is causing an assertion segfault in a `rustc` test over > at our experimental rust + llvm@head bot: > https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/buil

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

erichkeane added a comment. In D99134#3331359 , @davidstone wrote: > In D99134#3331259 , @rsmith wrote: > >> Looks good. Do you need someone to land this for you? > > Yes, I do. I'll do that for you, working on it

[clang] 0bff3a9 - Lambdas are not necessarily locals. This resolves DR48250.

Author: David Stone Date: 2022-02-18T06:11:28-08:00 New Revision: 0bff3a965022647fcdd17cc8f2217f5a2cd30b4c URL: https://github.com/llvm/llvm-project/commit/0bff3a965022647fcdd17cc8f2217f5a2cd30b4c DIFF: https://github.com/llvm/llvm-project/commit/0bff3a965022647fcdd17cc8f2217f5a2cd30b4c.diff L

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bff3a965022: Lambdas are not necessarily locals. This resolves DR48250. (authored by davidstone, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

erichkeane added a comment. In D99134#3311363 , @jloser wrote: > Would love to see this cherry-picked into the llvm 14 release branch if > possible! I believe there is a bug in github that you can use to request that. This just landed as 0bff3a96502264

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[clang-tools-extra] c24e197 - [clangd] getHover - pass FormatStyle argument by const reference

Author: Simon Pilgrim Date: 2022-02-18T14:45:51Z New Revision: c24e197aaad5333717a27f6e4346f97da84821ed URL: https://github.com/llvm/llvm-project/commit/c24e197aaad5333717a27f6e4346f97da84821ed DIFF: https://github.com/llvm/llvm-project/commit/c24e197aaad5333717a27f6e4346f97da84821ed.diff LOG:

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:491 + // We'll examine visible specializations and see if they yield a unique type. + bool VisitParmVarDecl(ParmVarDecl *PVD) { +if (!PVD->getType()->isDependentType()) Since this i

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. @krasimir Since I don't have a rust environment, can you help me to test if D120130 works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.l

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3332020 , @achieveartificialintelligence wrote: > @krasimir Since I don't have a rust environment, can you help me to test if > D120130 works? Hm, actually, looking at the log, it does

[clang-tools-extra] 707157f - Revert rGc24e197aaad5333717a27f6e4346f97da84821ed "[clangd] getHover - pass FormatStyle argument by const reference"

Author: Simon Pilgrim Date: 2022-02-18T14:59:57Z New Revision: 707157f24834e814243c90cf1f5f50c75f3abcb9 URL: https://github.com/llvm/llvm-project/commit/707157f24834e814243c90cf1f5f50c75f3abcb9 DIFF: https://github.com/llvm/llvm-project/commit/707157f24834e814243c90cf1f5f50c75f3abcb9.diff LOG:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. >> It appears that this is causing an assertion segfault in a rustc test over >> at our experimental rust + llvm@head bot: I dont think that patch author is required to debug this issue for "experimental rust + llvm@head" - downstream. >> Since I don't have a rust env

[PATCH] D120131: [clangd] prototype: for singly-instantiated templates, examine the instantiation

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This prototype is crude and breaks things (e.g. inc

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. In D93298#3332038 , @xbolva00 wrote: >>> It appears that this is causing an assertion segfault in a rustc test over >>> at our experimental rust + llvm@head bot: > > I dont think that patch author is required to debug this issue fo

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. In D93298#3332058 , @jrtc27 wrote: > In D93298#3332038 , @xbolva00 wrote: > It appears that this is causing an assertion segfault in a rustc test over at our experimental rust +

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. yaxunl requested review of this revision. The clang compiler prepends the HIP header include paths to the search list using -internal-isystem when building for the HIP language. This prevents wa

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccebf8ac8c61: [Clang][OpenMP] Add support for compare capture in parser (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES

[clang] ccebf8a - [Clang][OpenMP] Add support for compare capture in parser

Author: Shilei Tian Date: 2022-02-18T10:23:59-05:00 New Revision: ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c URL: https://github.com/llvm/llvm-project/commit/ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c DIFF: https://github.com/llvm/llvm-project/commit/ccebf8ac8c61cbd46223abbeb4f29f4e1f7b490c.diff L

[clang] 68b7b35 - [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

Author: Shilei Tian Date: 2022-02-18T10:24:29-05:00 New Revision: 68b7b357fdfc00ed8807a887eba363d67c9dc3f5 URL: https://github.com/llvm/llvm-project/commit/68b7b357fdfc00ed8807a887eba363d67c9dc3f5 DIFF: https://github.com/llvm/llvm-project/commit/68b7b357fdfc00ed8807a887eba363d67c9dc3f5.diff L

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

This revision was automatically updated to reflect the committed changes. Closed by commit rG68b7b357fdfc: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry updated this revision to Diff 409935. kuzkry added a comment. Review fix: added note about IndentRequires. The generated HTML looks like this: F22153448: IndentRequires note.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https:/

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/include/clang/Format/Format.h:2540-2541 ///} /// \endcode - /// \version 13 + /// \version 15 bool IndentRequiresClause; MyDeveloperDay wrote: > HazardyKnusper

[clang] 91cf639 - Fix Wdocumentation unknown parameter warning

Author: Simon Pilgrim Date: 2022-02-18T15:38:16Z New Revision: 91cf639ac069a797b1fac4134cf121bc9db6dff6 URL: https://github.com/llvm/llvm-project/commit/91cf639ac069a797b1fac4134cf121bc9db6dff6 DIFF: https://github.com/llvm/llvm-project/commit/91cf639ac069a797b1fac4134cf121bc9db6dff6.diff LOG:

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278 +} else if (llvm::sys::path::is_separator(Glob[I]) && + llvm::sys::path::

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

carlocab added a comment. Thanks Petr. I don’t have commit access, so I’d appreciate it if you could commit this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119144/new/ https://reviews.llvm.org/D119144 __

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. vabridgers requested review of this revision. Herald added a pr

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3565 else Ty = Context.CharTy; // 'x' -> char in C++ Perhaps worth updating this comment? e.g., // 'x' -> char in C++; u8'x' -> char in C11-C17 and in C++ without char8_t.

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278 +} else if (llvm::sys::path::is_separator(Glob[I]) && + llvm::sys::path::is_separator('/') && + llvm::sys:

[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b749e5be21: [clangd] Tweak --query-driver to ignore slash direction on windows (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D120115?vs=409900&id=409957#toc Repository:

[clang-tools-extra] 47b749e - [clangd] Tweak --query-driver to ignore slash direction on windows

Author: Sam McCall Date: 2022-02-18T18:06:36+01:00 New Revision: 47b749e5be2190d1ccb214fd6364da462a9098cf URL: https://github.com/llvm/llvm-project/commit/47b749e5be2190d1ccb214fd6364da462a9098cf DIFF: https://github.com/llvm/llvm-project/commit/47b749e5be2190d1ccb214fd6364da462a9098cf.diff LO

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

dblaikie added a comment. (maybe relevant: For what it's worth: I originally implemented inline function homing in modules codegen for Clang Header Modules - the results I got for object file size in an -O0 build were marginal - a /slight/ win in object file size, but not as much as we might've

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. >> That's not the first time we renamed something. And most likely not the last >> time. > > But that doesn't mean we can't add "Previously known as IndentRequires", does > it? :) Of course! I just wanted to say that

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53876. This is a solution for

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1740 +assert(Current.MatchingParen); +Current.MatchingParen->setType(TT_Unknown); + } To add some context, in the failing cases, the opening parenthesis was set t

[clang] 74036db - Fix Wdocumentation unknown parameter warning

Author: Simon Pilgrim Date: 2022-02-18T17:27:45Z New Revision: 74036dbafd3d742e86464043f3e2f4d52bf79f1e URL: https://github.com/llvm/llvm-project/commit/74036dbafd3d742e86464043f3e2f4d52bf79f1e DIFF: https://github.com/llvm/llvm-project/commit/74036dbafd3d742e86464043f3e2f4d52bf79f1e.diff LOG:

[clang-tools-extra] 9415fbb - [clangd] getHover - pass FormatStyle argument by const reference

Author: Simon Pilgrim Date: 2022-02-18T17:27:45Z New Revision: 9415fbbbcf73ab90692fafdac5bd6e302d07ba4b URL: https://github.com/llvm/llvm-project/commit/9415fbbbcf73ab90692fafdac5bd6e302d07ba4b DIFF: https://github.com/llvm/llvm-project/commit/9415fbbbcf73ab90692fafdac5bd6e302d07ba4b.diff LOG:

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

lattner added a comment. Hi all, I'm commenting on this based on my personal opinion, I don't speak for the LLVM board or anyone else. I am also not a lawyer :) This isn’t a clear cut case (as is typical!). LLVM's approach on patents protection revolves primarily around the terms in the Apach

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:464-473 + const char *v8691OrLater[] = {"+v8.6a", "+v8.7a", "+v8.8a", + "+v9.1a", "+v9.2a", "+v9.3a"}; auto Pos = std::find_first_of(Features.begin(),

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. Can I ask you to deliver this one for me? My name and email in git format is "Krystian Kuzniarek " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https://reviews.llvm.org/D119682 ___ cfe-commits mailing lis

[PATCH] D112916: Confusable identifiers detection

aaron.ballman added a comment. In D112916#3331592 , @cor3ntin wrote: > In D112916#3314184 , @cor3ntin > wrote: > >> @aaron.ballman Thanks for the ping. >> >> One one hand, I agree with you, on the other hand, thi

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3331658 , @nlopes wrote: > Well, this patch is just a band-aid and a disaster waiting to happen. > If kmalloc is tagged with an `__attribute__` stating the allocation size, > then you can't dereference beyond that li

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

nlopes added a comment. In D119816#3332414 , @ztong0001 wrote: > In D119816#3331658 , @nlopes wrote: > >> Well, this patch is just a band-aid and a disaster waiting to happen. >> If kmalloc is tagged with an `__at

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3331797 , @melver wrote: > Right, I was able to repro this. The problem is the trap, which generally > sucks that no_sanitize still leaves in the trap. > > We also have -fno-sanitize-undefined-trap-on-error, which se

[PATCH] D119816: Fix not working attribute no_sanitize bounds that affects linux kernel

ztong0001 added a comment. In D119816#3332441 , @nlopes wrote: > The main issue is that the kernel is wrong. It has a bug. The sanitizer's > error is not a false-positive! > So what you are proposing is a band-aid. It's not a real solution and it's > ju

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

urnathan added a comment. In D119409#3332313 , @dblaikie wrote: > That's interesting data. I guess one could emit the out-of-line bodies into their own sections, and then rely on linker section GC to elide them in the static link. But if you're buil

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

jdoerfert added a comment. FWIW, https://github.com/llvm/llvm-project/issues/53931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1951 +// FIXME: Maybe we should handle identifiers ending with "_cast", +// e.g. bit_cast? +return true; Very unlikely `bit_cast` gives you somethin

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp abandoned this revision. carlosgalvezp added a comment. Understood, thanks a lot for the clarification and for the time taken! I will then abandon this patch given the high risk involved. I will forward this feedback to MISRA in case there is a possibility to publish the upcoming

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3332521 , @jdoerfert wrote: > FWIW, https://github.com/llvm/llvm-project/issues/53931 Yes. Working on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/n

[PATCH] D120149: [clang][dataflow] Add support for global storage values

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:74-77 + auto *V = dyn_cast(&D); + if (V == nullptr) +return; + initGlobalVar(*V, Env); -

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 805f7a4 - [clang] Add `ObjCProtocolLoc` to represent protocol references

Author: David Goldman Date: 2022-02-18T15:24:00-05:00 New Revision: 805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1 URL: https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1 DIFF: https://github.com/llvm/llvm-project/commit/805f7a4fa4ce97277c3b73d0c204fc3aa4b072e1.diff

[clang-tools-extra] 54a962b - [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

Author: David Goldman Date: 2022-02-18T15:24:00-05:00 New Revision: 54a962bbfee86d5af90d5fdd39b4ff4ec8030f12 URL: https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12 DIFF: https://github.com/llvm/llvm-project/commit/54a962bbfee86d5af90d5fdd39b4ff4ec8030f12.diff

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG805f7a4fa4ce: [clang] Add `ObjCProtocolLoc` to represent protocol references (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rG54a962bbfee8: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1193

  1   2   >