vabridgers marked an inline comment as done.
vabridgers added inline comments.
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:372
- Loc makeNull() {
- return loc::ConcreteInt(BasicVals.getZeroWithPtrWidth());
}
----------------
steakhal wrote:
> steakhal wrote:
> >
> You should also remove the `BasicValueFactor::getZeroWithPtrWidth()` along
> with `BasicValueFactor::getIntWithPtrWidth()` since those suffer from the
> same issue.
> Feel free to do that in a separate patch.
Will do. I had also left "TODO" comments in a different source file. I'll find
those, clean those up also.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119601/new/
https://reviews.llvm.org/D119601
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
