sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278
+ } else if (llvm::sys::path::is_separator(Glob[I]) &&
+ llvm::sys::path::is_separator('/') &&
+ llvm::sys::path::is_separator('\\')) {
----------------
kadircet wrote:
> nit: maybe extract `llvm::sys::path::is_separator('/') &&
> llvm::sys::path::is_separator('\\')` into a `bool PlatformIsSlashInsensitive`
> ?
We require the separators to be exactly \ and / for the regex to be correct, so
I'd rather keep the literals here.
(Call me paranoid, but I grew up on a system with `:` for separators...)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120115/new/
https://reviews.llvm.org/D120115
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
