yaxunl marked an inline comment as done. yaxunl added inline comments.
================ Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + ---------------- yaxunl wrote: > tra wrote: > > Is this file necessary? `clang -###` should not need the file to be present > > in order to print out command lines. > You are right. Will remove it when committing. Sorry, AddStaticDeviceLibsLinking needs to determine the real path of the library by looking up multiple -L options, therefore it requires the file to exist. I forgot to delete the file when testing, so I thought the test passes without creating the file. After I delete it, the test fails. Therefore I have to add back the touch command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120070/new/ https://reviews.llvm.org/D120070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
