[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 409507. ChuanqiXu added a comment. Use ODRHash to simplify code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaTemplate.cp

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409510. junaire added a comment. - Only suppress canonical types when it's a TypedefNameType. - Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409511. junaire added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files: clang-tools-extra/clang-tidy/readability/Static

[clang] 0ae2464 - [clang-format] Fix wrong assertion with non-negative shift when aligning tokens.

Author: Marek Kurdej Date: 2022-02-17T09:49:00+01:00 New Revision: 0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2 URL: https://github.com/llvm/llvm-project/commit/0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2 DIFF: https://github.com/llvm/llvm-project/commit/0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2.diff

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains updated this revision to Diff 409521. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files: clang/include/clang/Basic/DiagnosticParseKinds.t

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains marked 5 inline comments as done. iains added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:82 if (getLangOpts().Modules || getLangOpts().DebuggerSupport) { - SingleDecl = ParseModuleImport(AtLoc); + Sema::ModuleImportState IS = Sema::ModuleImpor

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. I think we should add 2 more tests at least: Import a partition a module purview but we failed to find one. And test reflects the successful case. Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'import' k

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there iains wrote:

[clang] dd4dde8 - [clang][dataflow] Add transfer functions for logical and, or, not.

Author: Stanislav Gatev Date: 2022-02-17T09:09:59Z New Revision: dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd URL: https://github.com/llvm/llvm-project/commit/dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd DIFF: https://github.com/llvm/llvm-project/commit/dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd.diff LO

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4dde8d39a9: [clang][dataflow] Add transfer functions for logical and, or, not. (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains marked 4 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there ChuanqiXu wr

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); I chose '-' in my implementation since here ModuleName refers to the name in filesystem, ri

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/cxx20-partition-diagnostics-a.cpp:3-5 +// RUN: %clang_cc1 -std=c++20 -S -D TU=1 -x c++ %s -o /dev/null -verify + +// RUN: %clang_cc1 -std=c++20 -S -D TU=2 -x c++ %s -o /dev/null -verify We could use

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/cxx20-10-1-ex1.cpp:7-8 + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface -D TU=1 -x c++ %s \ +// RUN: -o %t/A_Internals.pcm + In my implementation, I replace ':' to '-' in pcm filename. I do s

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM with the name about partition CMI addressed (It is raised in previous patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:367-368 + // owning named module. + size_t P = NamedMod->Name.find_first_of(":"); + ModuleName = NamedMod->Name.substr(0, P + 1); +} else { ChuanqiXu wrote: > I would li

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

ChuanqiXu added a comment. hmmm, I don't find this is used in following patch. Oversight? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 ___ cfe-commits mailin

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added a comment. My implementation is StringRef getPrimaryModuleName() const { if (Check Kind) return Name; return StringRef(Name).split('-').first; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ ht

[clang] a480841 - Add missing break statement in switch.

Author: Stanislav Gatev Date: 2022-02-17T09:37:02Z New Revision: a48084156653e8f3791d13c19ce64df13c44a11e URL: https://github.com/llvm/llvm-project/commit/a48084156653e8f3791d13c19ce64df13c44a11e DIFF: https://github.com/llvm/llvm-project/commit/a48084156653e8f3791d13c19ce64df13c44a11e.diff LO

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Sorry, I took an oversight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 __

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains updated this revision to Diff 409546. iains added a comment. amended an assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/inc

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

iains updated this revision to Diff 409548. iains marked an inline comment as done. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 Files:

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 409552. iains added a comment. address review comments, rebase onto parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files: clang/include/clang/AST/Dec

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. Posted D120026 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116088/new/ https://reviews.llvm.org/D116088 ___ cfe-commits mailing list cfe-c

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

RKSimon added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:453 +return "uwtable"; + return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") + + ")") @chill Static analysis is warning that its impossible to hi

[PATCH] D120028: [clang-format] Do not add space after return-like keywords in macros.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/6. Repository: rG LLVM

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma reopened this revision. efriedma added a comment. This revision is now accepted and ready to land. Reverted in 0389f2edf7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D119686: [RISCV] Add the passthru operand for nomask vadc/vsbc/vmerge/vfmerge IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG093ecccdab47: [RISCV] Add the passthru operand for vadc/vsbc/vmerge/vfmerge IR intrinsics. (authored by khchen). Repository: rG LLVM Github Monore

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains marked 7 inline comments as done. iains added a comment. some comments remain to be addressed - this update addressed Nathan's primarily - but also cover some of Chuanqi's Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'impor

[clang] 5065076 - [CodeGen] Rename deprecated Address constructor

Author: Nikita Popov Date: 2022-02-17T11:26:42+01:00 New Revision: 5065076698cf32b5ad3b6f88b5f3b84d68948589 URL: https://github.com/llvm/llvm-project/commit/5065076698cf32b5ad3b6f88b5f3b84d68948589 DIFF: https://github.com/llvm/llvm-project/commit/5065076698cf32b5ad3b6f88b5f3b84d68948589.diff

[PATCH] D119599: Add option to align compound assignments like `+=`

curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:163 + /// \endcode + bool AlignCompoundAssignments; + sstwcw wrote: > curdeius wrote: > > HazardyKnusperkeks wrote: > > > MyDeveloperDay wrote: > > > > This option is not independen

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. A believe that all of Kiran's comments have been addressed and pre-merge CI is also passing now (that was one of the concerns). Kiran has not accepted this yet, but he will be away for a few weeks. I will merge this as is to unblock further work. I more than happy to

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:453 +return "uwtable"; + return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") + + ")") RKSimon wrote: > @chill Static analysis is warning that its i

[clang] 9798b33 - [OpenCL] Guard 64-bit atomic types

Author: Sven van Haastregt Date: 2022-02-17T10:58:52Z New Revision: 9798b33d1dc14f5334e2cc117e3896510fa57b82 URL: https://github.com/llvm/llvm-project/commit/9798b33d1dc14f5334e2cc117e3896510fa57b82 DIFF: https://github.com/llvm/llvm-project/commit/9798b33d1dc14f5334e2cc117e3896510fa57b82.diff

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9798b33d1dc1: [OpenCL] Guard 64-bit atomic types (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Most places already seem to use the short spelling instead of 'unsi

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Obviously

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron added a comment. A friendly ping =) Seems like I don't have write access, so unfortunately I have to ask people to merge commits on my behalf. Let me copy-paste the usual comment of my reviews: //P.S. If this review is eventually approved, kindly please merge the commit on my behalf =)

[PATCH] D119409: [C++20] [Modules] Remain internal-linkage variables in module interface unit

urnathan added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG: @inline_var_e

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[clang] e993b20 - [flang][driver] Add support for `-emit-llvm`

Author: Andrzej Warzynski Date: 2022-02-17T12:13:03Z New Revision: e993b20c049d2f933831c26139f024e022f3d7fe URL: https://github.com/llvm/llvm-project/commit/e993b20c049d2f933831c26139f024e022f3d7fe DIFF: https://github.com/llvm/llvm-project/commit/e993b20c049d2f933831c26139f024e022f3d7fe.diff

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe993b20c049d: [flang][driver] Add support for `-emit-llvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://revie

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); iains wrote: > ChuanqiXu wrote: > > I chose '-' in my implementation since here ModuleName re

[PATCH] D120032: [OpenCL] opencl-c.h: use uint/ulong consistently

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120032/new/ https://reviews.llvm.org/D120032 _

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda added a comment. @tra I've fixed the test failure (`math-intrins.ll`) the rest seems to be unrelated timeouts, would you be able to merge those patches in, as I don't have the commit access please? The same goes for https://reviews.llvm.org/D117887 and https://reviews.llvm.org/D119157

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

rovka accepted this revision. rovka added a comment. I'm happy if the buildbots are happy :D thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-com

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DI

[clang] 2614de8 - [clang] CGCXXABI::EmitLoadOfMemberFunctionPointer - use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-02-17T13:18:23Z New Revision: 2614de82025bd9c04f8515747a611238c0ac4e05 URL: https://github.com/llvm/llvm-project/commit/2614de82025bd9c04f8515747a611238c0ac4e05 DIFF: https://github.com/llvm/llvm-project/commit/2614de82025bd9c04f8515747a611238c0ac4e05.diff LOG:

[clang] 57fc979 - [clang] CGDebugInfo::getOrCreateMethodType - use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-02-17T13:18:23Z New Revision: 57fc9798d7145626809b0e81af9154a755b383eb URL: https://github.com/llvm/llvm-project/commit/57fc9798d7145626809b0e81af9154a755b383eb DIFF: https://github.com/llvm/llvm-project/commit/57fc9798d7145626809b0e81af9154a755b383eb.diff LOG:

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:3 +// RUN: %clang_cc1 %s -emit-llvm -triple aarch64-unknown-unknown -o - | FileCheck %s --check-prefix=AARCH64 +// REQUIRES: aarch64-registered-target + There's nothi

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3225908 , @erichkeane wrote: > In D114425#3225892 , @craig.topper > wrote: > >> I kind of wonder if we should detect the __int128 type being requested in >> ASTContext::GetBu

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 409607. philnik added a comment. - Rebased - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[clang-tools-extra] 1c502c6 - [clang-doc] SerializeIndex - pass Index param by constant reference

Author: Simon Pilgrim Date: 2022-02-17T13:28:02Z New Revision: 1c502c63cb77dd15e698087fdc6b3fb892ce0977 URL: https://github.com/llvm/llvm-project/commit/1c502c63cb77dd15e698087fdc6b3fb892ce0977 DIFF: https://github.com/llvm/llvm-project/commit/1c502c63cb77dd15e698087fdc6b3fb892ce0977.diff LOG:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. In that case, LGTM (needs a rebase though). Thanks for your patience on this @achieveartificialintelligence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added a comment. In D114425#3329303 , @philnik wrote: > In D114425#3225908 , @erichkeane > wrote: > >> In D114425#3225892 , @craig.topper >> wrote: >> >>> I kin

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 409614. iains marked 9 inline comments as done. iains added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files: clang/include/cl

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); urnathan wrote: > iains wrote: > > ChuanqiXu wrote: > > > I chose '-' in my implementation since

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3322312 , @ro wrote: > In D91605#3321554 , @MaskRay wrote: > >> `GetTls` is about the static TLS block size. It consists of the main >> executable's TLS, and initially loaded shared ob

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. achieveartificialintelligence marked an inline comment as done. Closed by commit rG7798ecca9c3d: [RISCV] add the MC layer support of Zfinx extension (authored by achiev

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks Comment at: clang-tools-extra/clangd/unittests/SerializationTests.cpp:313 // Sanitizers use a lot of address space, so we can't apply strict limits. -#if LLVM_ON_

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 _

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Thanks all! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

asb added a comment. Thanks, I've put this on the agenda for the RISC-V LLVM sync call today. I think this is more attractive than the previous proposal due to unifying logic between llc and Clang. I could see a counter-argument about llc being a low-level tool that should be controlled very ex

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D114425: [clang] Add __builtin_bswap128

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10987 case 'i': -if (HowLong == 3) +if (HowLong == 3) { + if (!AllowInt128 && !Context.getTargetInfo().hasInt128Type()) { Please add a test in Sema as well to validate the

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart requested review of this revision. iannisdezwart added a comment. Would be nice if this can further be reviewed and commited to the repo! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 ___

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array tbaeder wrote: >

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. lld-macho folks, any concerns with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 409627. iains marked 2 inline comments as done. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/in

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains added inline comments. Comment at: clang/test/Modules/cxx20-10-1-ex1.cpp:7-8 + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface -D TU=1 -x c++ %s \ +// RUN: -o %t/A_Internals.pcm + ChuanqiXu wrote: > In my implementation, I replace ':' to '-' in pcm f

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 409629. philnik marked an inline comment as done. philnik added a comment. Herald added a subscriber: mstorsjo. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D11

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 409633. iains added a comment. rebased onto changes in parent patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

jrtc27 added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:641 +getASTContext().getTargetInfo().getTriple().getArch(); +if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_be || +Arch == llvm::Triple::arm || Arch == llvm::Triple::

[PATCH] D120055: [asan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added reviewers: melver, dvyukov, eugenis. Herald added a subscriber: hiraditya. glider requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For ASan this will effectively serve as a synonym

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 409637. iains added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp cla

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

urnathan added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +APValue

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

MyDeveloperDay added a comment. A noble effort. It needs someone like yourself to do this as you already have a deep understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120034/new/ https://reviews.llvm.org/D120034 ___

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

sfertile added a comment. Hey Zarko. I really like how we only issue the warning when the struct is used, however I think this is still overly broad because of where the incompatibility lies between xlc and clang. I believe the layout of the structures will be the same for both compilers, and g

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

iains updated this revision to Diff 409645. iains added a comment. rebased onto parent patch changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h clang/lib/Se

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added a comment. In D91605#3329375 , @ro wrote: > > As an experiment, I've tried to use `GetStaticTlsBoundary` instead. It does > indeed work on recent Solaris 11.4 and the resulting patch is at D120048 > . I'm

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? @thakis I wasn't able to reproduce the issue with Modules/cxx20-export-import.cpp locally (tried a couple of build

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

curdeius added a comment. That would be a nice improvement... and a big undertaking at the same time. You have my blessing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120034/new/ https://reviews.llvm.org/D120034 ___

[PATCH] D120061: [libclang] add support for arrays to clang_Cursor_Evaluate

BartmanAbyss created this revision. BartmanAbyss added reviewers: klimek, rsmith, akyrtzi. BartmanAbyss added projects: clang-c, clang. Herald added a subscriber: arphaman. BartmanAbyss requested review of this revision. Herald added a subscriber: cfe-commits. This allows evaluating array initiali

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Sure, sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e17c9613f36: [AArch64] Add some missing strict FP vector lowering (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 409665. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/clang/Basic/Module.h clang/lib/S

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains updated this revision to Diff 409666. iains marked an inline comment as done. iains added a comment. remove stray blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/ https://reviews.llvm.org/D118598 Files: clang/include/cl

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/double-mem.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d -verify-machineinstrs < %s \ +; RUN: llc -mtriple=riscv32 -mattr=+d -target-abi=

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:523-524 + std::string getPrimaryModuleInterfaceName() const { +std::string::size_type pos = Name.find(':'); +if (pos == std::string::npos) + return Na

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120065 Files: clang/include/clang/AST/DeclTem

[PATCH] D120066: FileCheck’s regexp stumped on Windows.

zahiraam created this revision. zahiraam added a reviewer: erichkeane. zahiraam requested review of this revision. Herald added a project: clang. We found that on Windows the regular expression used to describe the link command from the last RUN command of the LIT test debug-info-hotpatch.cpp, is

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclTemplate.h:2464 FriendTemplateDecl(DeclContext *DC, SourceLocation Loc, - MutableArrayRef Params, +

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

iains updated this revision to Diff 409671. iains added a comment. rebase onto parent patch changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599 Files: clang/lib/Sema/SemaLookup.cpp clang/test/Mod

[clang] 0b57e6c - [objcopy] followup patch after f75da0c8e65cf1b09012a8b62cd7f3e9a646bbc9

Author: Alexey Lapshin Date: 2022-02-17T19:32:10+03:00 New Revision: 0b57e6c46b707c0e7a123efe82abf3c1e7b5a503 URL: https://github.com/llvm/llvm-project/commit/0b57e6c46b707c0e7a123efe82abf3c1e7b5a503 DIFF: https://github.com/llvm/llvm-project/commit/0b57e6c46b707c0e7a123efe82abf3c1e7b5a503.diff

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

urnathan added a comment. please remind me when this is committed that I'll need to adjust D118352 -- at the moment that's searching for ':' to determine partitionness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D120066: FileCheck’s regexp stumped on Windows.

erichkeane added a comment. Commit message isn't particularly good either. Perhaps something like: > [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue > > In our downstream, we discovered that the that the `.*` wildcard > in debug-info-hotpatch.cpp (added https://reviews.l

  1   2   3   >