jrtc27 added inline comments.
================ Comment at: clang/lib/AST/ItaniumMangle.cpp:641 + getASTContext().getTargetInfo().getTriple().getArch(); + if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_be || + Arch == llvm::Triple::arm || Arch == llvm::Triple::armeb) ---------------- Could use isAArch64 (which then also picks up aarch64_32) ================ Comment at: clang/lib/AST/ItaniumMangle.cpp:642 + if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_be || + Arch == llvm::Triple::arm || Arch == llvm::Triple::armeb) + return getStdNamespace(); ---------------- Could use isARM. Does this also need to care about isThumb, or has that been normalised to Arm with a T32 subarch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
