erichkeane added a comment. Commit message isn't particularly good either.
Perhaps something like: > [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue > > In our downstream, we discovered that the that the `.*` wildcard > in debug-info-hotpatch.cpp (added https://reviews.llvm.org/D116511) > ended up matching the entire line on our Windows configurations, causing > the `-function-padmin` check to already be consumed. After digging into it > we weren't able to find any sort of reason why the platform would matter > here, however we suspect there must be some difference in the regex matcher > between systems. > > This NFC patch replaces the regex with a more conservative regex that prevents > this from happening by replacing the `.` match with an 'everything but double- > quote match, `[^"]`. ================ Comment at: clang/test/CodeGenCXX/debug-info-hotpatch.cpp:16 +// FUNCTIONPADMIN: {{link[^"]*"}} +// FUNCTIONPADMIN: "-functionpadmin" ---------------- This part of the change shouldn't be necessary, right? I'd probably prefer not to have this part unless needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120066/new/ https://reviews.llvm.org/D120066 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
