aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/test/CMakeLists.txt:91
+ if(TARGET CTTestTidyModule)
+ list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello)
+ target_include_directories(CTTestTidyModule PUBLIC BEFORE
"${CLANG_TOOLS_SOURCE_DIR}")
----------------
tstellar wrote:
> Our stand-alone builds for Fedora are still not working after this patch,
> even with D119199. Why is it necesary to add LLVMHello as a test dependency?
> Which test is using it?
CTestTidyModule.cpp is using it:
```
// RUN: clang-tidy -checks='-*,mytest*' --list-checks -load
%llvmshlibdir/CTTestTidyModule%pluginext -load
%llvmshlibdir/LLVMHello%pluginext | FileCheck --check-prefix=CHECK-LIST %s
```
I *think* this is testing that we can load a clang-tidy plugin and an llvm
plugin at the same time and not hit conflicting symbols or other issues. If I'm
correct, then I think that's useful test functionality, but I wouldn't describe
it as critical, so I'd be fine if we dropped it for now to get this patch in,
and then added the extra testing in a subsequent patch if we think it's
necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111100/new/
https://reviews.llvm.org/D111100
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
