aaron.ballman added inline comments.
================ Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:3 +// RUN: %clang_cc1 %s -emit-llvm -triple aarch64-unknown-unknown -o - | FileCheck %s --check-prefix=AARCH64 +// REQUIRES: aarch64-registered-target + ---------------- There's nothing AArch64-specific about the change, so I'd expect some more general codegen tests. Actually, I took a look to see what calls `getFloatingTypeOfSizeWithinDomain()` and I can't find any callers of that. Do you have a test case where you were hitting that particular unreachable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
